Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Yarn Workspaces #62

Closed
wants to merge 5 commits into from
Closed

Conversation

jamiebuilds
Copy link
Contributor

@jamiebuilds jamiebuilds commented May 5, 2017

@bestander
Copy link
Member

Hey @thejameskyle, that is a nice document you've had hidden from us :)

We've been considering trade offs and implementation details for months and decided to go with the phased approach. It's too large for one person to claim ownership over the full feature and we invite you to participate in the phased approach.

I have set up phases in this issue yarnpkg/yarn#3294.
If you like you can claim a piece of it from RFC to full implementation.

@jamiebuilds
Copy link
Contributor Author

I'm aware of that, I was in those meetings early on 😛

There's nothing about this that cannot be broken down into phases, but the feature should really be considered all at once.

Also, I shared the private gist with you and @cpojer months ago

@torifat
Copy link
Member

torifat commented May 6, 2017

Right now we use a question field to manually type in a version. However, we should change that to a multi-choice selector (See Inquirer.js).

Recently I moved Inquirer inside our ConsoleReporter. I was thinking about refactoring the question/select. It will improve DX of several workflows.


# Detailed design

This is the bulk of the RFC. Explain the design in enough detail for somebody

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this section need to be deleted, or filled in? Looks like boilerplate.

@bestander
Copy link
Member

Hey, @thejameskyle, thanks for sending this RFC, very inspiring.

Currently we think that we can address specifics faster in a phased approach that I track in yarnpkg/yarn#3294.

Having focused discussions around particular isolated features allows us to have a faster turnaround and also experiment with code as the discussions happen.

Your spec has a good coverage around publishing experience and you have plenty related experience from lerna, do you want to champion that part of workspaces from RFC to implementation?

@cpojer
Copy link

cpojer commented Jun 1, 2017

Closing this PR as it was superseded by the RFCs for Workspaces phase 1, 2 and 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants