Move inquirer code to console reporter #3207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torifat
commented
Apr 20, 2017
| output: this.stdout, | ||
| }); | ||
|
|
||
| let rejectRef = () => {}; |
There was a problem hiding this comment.
I didn't like doing this at all. Please feel free to suggest any better alternative.
|
Cool stuff! |
This was referenced Apr 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a long time due.
When I first wrote it I had no idea about the rest of the yarn codebase. Later I realized it would be a better idea to move this inside the reporter. Then we can easily use this in other parts of our codebase.
Future Wok
Fix press double(done)ctrl+cto get out of interactive mode