-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate hawtio-kubernetes-api to react (and remove angular dependency) #140
Comments
Just FYI, I had investigated at #67 whether we could move from our own hawtio-k8s-api to some more official like https://github.com/kubernetes-client/javascript, but it turned out it's only for server-side (Node): So we are sure we need to keep it and refresh it to React for hawtio-online v2. |
What about this one -> https://github.com/godaddy/kubernetes-client ?? Seems to have an API and |
When we consider 3rd party libs to substitute from our own impl, we should take sustainability into account, as we receive many security issues on a variety of components. If a 3rd party lib we use is abandoned, we'd need to end up patching it or rewrite it ourselves. I'm concerned that this project hasn't been updated for 3 years. I think this time it's most straightforward to keep our own module and migrate hawtio-k8s-api to React or framework-free. Looking at the core part, it doesn't seem to depend so much on AngularJS. Simply removing the AngularJS API from the code doesn't seem to be so difficult. |
On the other hand, we can consider using testing frameworks like this more easily as they should be dev only dependents and we can normally take security issues from those testing tools as moderate. |
* Removes nested kubernetes-api workspace in favour of making its sub-modules first-class citizens of main root workspace. * Only reason for nesting was to "hide" the k8-api testing app. However, given time this can be converted into one of the full testing apps for hawtio-online so hiding it is unnecessary. Fixes #140 (4)
* No longer required. Fixes #140 .7
* Installs the plugin-interactive-tools plugin to enable `upgrade-interactive` * Executes upgrade on all sub-modules Fixes #140 .5
Migrated to 2.x branch and then to be main |
Ensure each sub-module contains a
tsup.config.ts
config file, thereby mandating a uniform standard of output naming. Defineentry
, and specify it assrc/index.ts
;Every module should provide
index.ts
as its entrypoint. Then themain
andtypes
properties in thepackage.json
will always be standardized;Ensure correct module federation by adding
@hawtio/react
as a singleton in the webpack build configuration. This may well alleviate issues withjs-logging
not being defined;Nest workspaces are still under investigation as valid configuration for yarn v2+ (see this). So avoid them for the moment. Any test apps should be hoisted to top level;
package.json
dependencies
/devDependencies
are quite old everywhere. Need to upgrade them and remove unnecessary ones to keep up withhawtio-next
;File naming for independent plugin: not necessary to add plugin prefix to each file, as the plugin package should be independent with no concerns to taint global namespace;
eventemitter.d.ts
is not required. Thed.ts
should be provided already from the lib;urljs
should be replaced. The project itself states, there's no reason to use this lib anymore;Investigate extensions of the
hawtio-next
eventService
to make it available for hawtio-k8s-api.The text was updated successfully, but these errors were encountered: