feat: revise Favorites by introducing active folder to reduce ambiguity

[shenlebantongying]

Implement #2178 (comment)

---

Breakage / Enhancement:

Original GD's folder is ambiguous, group->folder mapping only maps the name.

a & b->a are considered the same.
|
| -> a
| -> b -> a
|    | -> c

Now requires the path fully specified like b/a for b->a folder and a is for folder a that is directly under top level only.

The group->folder is now only used when switching groups. Switching to a new group -> auto active folder of chosen.

---

Coding:

The central data is just a QStringList hat represents the nested folder.

Then various accompanying methods to utilize it.

---

Main idea: the 🌟 now associated with the active folder and consider the top level as the default folder.

• Add a new icon to indicate the active folder that is associated with the 🌟
• 🌟 -> word in
  • click -> remove word from current active folder.
• ⚪ -> word not in
  • click -> add word to current active folder
• Add a new action: Double click folder icon to make it the active folder
  • Edit: it is occupied by folding 😅
• If old Group->Folder association exists, then set that folder to the active folder

[xiaoyifang]

issue 1:
group failed

goldendict_rqIIeXXzQj.mp4

issue 2:
the word is already in the folder,

[shenlebantongying]

issue 1 is fixed.

Not sure about what issue 2 means, but I changed wording.

The Active is the new concept.

The original Add button need to revise:

• in the context menu -> add to the current selected folder
• in the main menu -> add to the active folder

---

The original GD's implementation is fusing main menu's fav and favPaneWidget's menu together.

Maybe just don't bring main menu's fav into the favPaneWidget's menu.

The main menu will have Export & Import & Add to active folder as operation on all items.

The context menu is editing the favPaneWidget including add to current selected folder.

[shenlebantongying]

BTW, the Hide is a duplication of View->Favoriate pane.

I just going to merge them.

Edit: history pane has the same issue.

[shenlebantongying]

How about we rebrand this feature to “Bookmarks” to align with browsers.

[xiaoyifang]

How about we rebrand this feature to “Bookmarks” to align with browsers.

not the same senario, one deals with url while the other deals with word. maybe leave it for later discussion. not in this one PR

[xiaoyifang]

Not sure about what issue 2 means, but I changed wording.

issue 2,the word in already in the active folder, but the text is save favorite to this folder

[shenlebantongying]

This can be merged as is.

The favourites have various other issues unrelated to this feature.

[xiaoyifang]

issue 3:

when the folder a is not active , the add actually adds the word to the active folder. Which leads to misunderstanding.

I would suggest add to the current selected folder ,if there is none selected then add to the active folder. If there is no active folder neither, add to the root .

[xiaoyifang]

issue 4;

The group's favorite folder is set to d/c/b/a , there is no folder is set active folder which IMO is right,then click the icon

.

the word was added to root folder a.

the word should be added to root (consider there is no such favorite folder ) or create the actual folder d/c/b/a as it does not exist and then add the word

[shenlebantongying]

issue 3 is fixed by removing it for now. Need to decouple two menus #2189 (comment)

issue 4 require a manually created folder for now. (Part of issue 4 is fixed by early return)

They will be done next time (new PRs). #2194

[shenlebantongying]

The early return should be fixed now.

---

There is another issue: original GD automatically switching group when clicking word and the word is in user's group->folder association.

I think this is another design error, because when clicking other word without group->folder association. There is no way to know what group to switch back.

Anyway, I retain this design for now. And I added this to

• New favorites pane enhancement ideas #2194 .

Let's hear some feedbacks.

[shenlebantongying]

Also note that this feature is not recursive.

Consider this one:

if recursive for word `b`
Init state -> 🌟 -> click -> remove from `f2` -> 
 New state -> ⚪ -> click ->      add to `f1`
                                         ^ inconsistency here
This is less powerful, because recursive makes it hard to manage f1 without affecting f2

if not recursive for word `b`
Init state -> ⚪ -> click ->      add to `f1` -> 
 New state -> 🌟 -> click -> remove from `f1`
                                         ^ preditable here
This is more powerful because user can could add/remove word in f1 & f2 independently

.
├── a
├── f1  <- active
│   ├── f2
│   │   ├── a
│   │   ├── b
│   │
│   ├── c

[sonarqubecloud]

Quality Gate passed

Issues
18 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[xiaoyifang]

if not recursive for word `b`
Init state -> ⚪ -> click ->      add to `f1` -> 
 New state -> 🌟 -> click -> remove from `f1`
                                         ^ preditable here
This is more powerful because user can could add/remove word in f1 & f2 independently

I like this one ,when f1 is active or selected . selected should have more high priority than active. This can be left for further discusion or in #2194 .

[xiaoyifang]

still a little complex , but this can do for now.