opt:favorite icon adjustment,allow more situation #2178
Conversation
xiaoyifang
commented
Feb 19, 2025
•
| icon | |
|---|---|
 |
word contain in both current associated folder and existed in other folders as well |
 |
not existed in current associated folder but existed in other folders |
 |
not in favorite |
 |
in current associate folder |
src/common/globalbroadcaster.hh
Outdated
| //key hold the headword, value holds the folders. | ||
| QMap< QString, QSet< QString > > folderFavoritesMap; |
There was a problem hiding this comment.
Maybe name this thing better?
https://www.google.com/search?q=map+naming+convention
wordToFavoritesFolders(Map),wordToFavFolders(Map)wordFavoritesFoldersMap,wordFavFoldersMap(get)FavoritesFoldersByWord,(get)FavFoldersByWord
42161e2 to
b3fda44
Compare
| QIcon emptyIcon = QIcon( ":/icons/star.svg" ); | ||
| QIcon fullIcon = QIcon( ":/icons/star_blue.svg" ); | ||
| QIcon emptyFullIcon = QIcon( ":/icons/star_other.svg" ); | ||
| QIcon fullFullIcon = QIcon( ":/icons/star_blue_other.svg" ); |
There was a problem hiding this comment.
I doubt if most of the users could infer the meaning of 4 states of this icons 😕 .
Cannot we have it simpler?
- 🌟 "blue" icon -> in favorites regardless of group/folder choice
- ⚪ empty -> not in favorites regardless of group/folder choice
I guess the original intention was to let a user putting word directly into a folder.
Currently, without associating a group with a folder, the word will end up in fav's top most level.
How about we just associate with the current active selected folder instead.
This fix the original issue of "not be able to put word to folder directly" and also reduces complexity by decoupling group⇄folder association.
For example, when clicking the star icon, the word will end up in the selected favoriate folder.
If I design this from scratch, I won't do the original GD's group->folder association 😄.
But we can keep this feature
click star icon:
if (have group->folder association)
put word in the group's folder choice
else
put word in current actively selected favoriate folder.
or top level if no folder is selected.
There was a problem hiding this comment.
if (have group->folder association)
put word in the group's folder choice
else
put word in current actively selected favoriate folder.
or top level if no folder is selected.
Actually I want to remove this constraint in the future completely . Only leave put word in the current selected folder
|
4 states icons is way too complex. The fact that no suitable icon is there just speaks the problem itself. Also see Firefox & Chrome's star icon, they only state that a page is bookmarked somewhere. 
|
|
icons/star_blue_other.svg
Outdated
There was a problem hiding this comment.
Not gonna to lie. This is not good.
It is hard to guess what this means without knowing the concept of "this folder" and "other folder". Even after knowing what it is, there is no good representation of the concept.
Also, Red is often associated with warnings. This would also be frustrating without knowing what this is (like the red dot notification in phone apps).
The original GD's "existing in this or other folder" concept is not that useful.
Let's just don't bring major confusion.
There was a problem hiding this comment.
Also, Red is often associated with warnings
maybe change the style , blue?
users can learn :-)
the chrome's favorite strategy is not good enough . |
|
How about we associate the icon with only the active folder
This is perfect design
|
This is better ,and can be left in another PR. maybe first try to decouple the association between favorite and group Current choice : associate group with favorite folder will cause much trouble ,such as this .
|
