-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opt:favorite icon adjustment,allow more situation #2178
Closed
+439
−36
Closed
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
b3fda44
opt:favorite global data structure adjust
xiaoyifang 105d812
opt: favorite icon
xiaoyifang fbffad0
opt: favorite icon
xiaoyifang 59ec2c3
[autofix.ci] apply automated fixes
autofix-ci[bot] 8b79b97
opt: favorite icon
xiaoyifang 73a8b76
opt: favorite icon
xiaoyifang 3c1a0d8
opt: favorite icon
xiaoyifang e207c87
[autofix.ci] apply automated fixes
autofix-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
// | ||
// Created by xiaoyifang on 2025/2/21. | ||
// | ||
|
||
#include "favoritemanager.hh" | ||
#include "globalbroadcaster.hh" | ||
FavoriteType FavoriteManager::determineFavoriteType( const QString & word, unsigned groupId ) | ||
{ | ||
QString folder = GlobalBroadcaster::instance()->groupFolderMap[ groupId ]; | ||
return determineFavoriteType( word, folder ); | ||
} | ||
|
||
FavoriteType FavoriteManager::determineFavoriteType( const QString & word, const QString & folder ) | ||
{ | ||
if ( !GlobalBroadcaster::instance()->wordFavoriteFolderMap.contains( word ) ) { | ||
return FavoriteType::EMPTY; | ||
} | ||
if ( folder.isEmpty() ) { | ||
return FavoriteType::FULL; | ||
} | ||
|
||
if ( GlobalBroadcaster::instance()->wordFavoriteFolderMap[ word ].contains( folder ) ) { | ||
if ( GlobalBroadcaster::instance()->wordFavoriteFolderMap[ word ].size() == 1 ) { | ||
return FavoriteType::FULL; | ||
} | ||
else { | ||
return FavoriteType::FULL_OTHER; | ||
} | ||
} | ||
return FavoriteType::EMPTY_OTHER; | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not gonna to lie. This is not good.
It is hard to guess what this means without knowing the concept of "this folder" and "other folder". Even after knowing what it is, there is no good representation of the concept.
Also, Red is often associated with warnings. This would also be frustrating without knowing what this is (like the red dot notification in phone apps).
The original GD's "existing in this or other folder" concept is not that useful.
Let's just don't bring major confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe change the style , blue?
users can learn :-)