Favorite: if word in a folder of favorite, use star_blue.svg instead of star.svg

[lengyijun]

If no group set

[lengyijun]

If group set to all, a word should be marked as favorited is it's saved in any path

[shenlebantongying]

It looks like the feature is already implemented?

goldendict-ng/src/ui/mainwindow.cc

Lines 2011 to 2023 in 5bcc3aa

	if ( index == ui.tabWidget->currentIndex() ) {
	// Set icon for "Add to Favorites" action
	if ( isWordPresentedInFavorites( title, cfg.lastMainGroupId ) ) {
	addToFavorites->setIcon( blueStarIcon );
	addToFavorites->setToolTip( tr( "Remove current tab from Favorites" ) );
	}
	else {
	addToFavorites->setIcon( starIcon );
	addToFavorites->setToolTip( tr( "Add current tab to Favorites" ) );
	}
	updateWindowTitle();
	}

Though, based on the implementation, it might not work on KDE/Linux due to this bug #1484

[xiaoyifang]

The logic for bookmarks is not very user-friendly. Currently, each group can be associated with different folder groups in the bookmarks. This leads to several issues. For example, if word A is in folder F1, the icon indicates that it is bookmarked. If the user navigate to folder F2 in the bookmarks panel, what icon should be used(bookmarked or not?) Should the user be allowed to add this word again to folder F2? When deleting word A, should it be removed from F1, or from both F1 and F2

[shenlebantongying]

This is fixed and not fixed.

Fixed -> the meaning of ⭐ is now clear and more flexible.

Not fixed -> now it indicates the current folder or the top level (non recursive).