Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the bottom-sheet cells non interactive when no action is attached directly to them #3404

Merged

Conversation

hypest
Copy link
Contributor

@hypest hypest commented Apr 21, 2021

Fixes #2633

Gutenberg PR: WordPress/gutenberg#31052

To test:

Please check the "How has this been tested" section in the GB PR.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 21, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@antonis antonis self-requested a review April 21, 2021 16:47
Copy link

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hypest
Copy link
Contributor Author

hypest commented Apr 22, 2021

The iOS full-test failure is a known issue and fixed already in WordPress/gutenberg#31053. Will run again just to be sure, after merging the Gutenberg PR and updating from there. Edit: updated and set the PR to auto-merge-on-green-CI.

@hypest hypest enabled auto-merge April 22, 2021 08:50
@hypest hypest merged commit 67818ce into develop Apr 22, 2021
@hypest hypest deleted the issue/2633-remove-press-action-on-non-interactive-cell-roots branch April 22, 2021 09:12
@cameronvoell cameronvoell added this to the 1.52.0 (17.3) milestone May 1, 2021
@cameronvoell cameronvoell mentioned this pull request May 1, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android - Remove press action on sliders
3 participants