[RNMobile] Mark TouchableRipple disabled if not editable or tappable #31052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Size Change: 0 B Total Size: 1.47 MB ℹ️ View Unchanged
|
|
I also tested on the iOS simulator and I didn't notice any regression ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses wordpress-mobile/gutenberg-mobile#2633
Tweaks the bottom-sheet cell component to make it not respond to direct taps/long-presses if it's not actually hosting a direct action. Children are still interactive.
How has this been tested?
Test 1:
Test 2:
Types of changes
Tweak the
disabledprop value we pass toTouchableRippleso the component will not provide feedback on taps when the cell is not offering a direct interaction.Checklist:
*.native.jsfiles for terms that need renaming or removal).