[RNMobile] Fix block insertion UI test #31053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Media picker is now automatically displayed when adding an image block so we have to include this case in the UI tests.
|
Size Change: 0 B Total Size: 1.47 MB ℹ️ View Unchanged
|
2 tasks
jd-alexander
approved these changes
Apr 21, 2021
There was a problem hiding this comment.
Thanks for these changes @fluiddot Verified that the tests work as expected by running them locally and I also noticed that the optional tests passed. LGTM 🚢 I will merge these changes since it's a minor fix and we want to avoid failure of the scheduled tests.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#3406
Description
Fix the block insertion UI test (part 2) by closing the media picker when the image block is added. This is related to the changes introduced to simplify the media flow in this PR.
How has this been tested?
npm run native test:e2e:ios:localto run the UI testsGutenberg Editor tests for Block insertion 2)Screenshots
N/A
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).