Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix block insertion UI test #3406

Merged
merged 2 commits into from
Apr 21, 2021
Merged

Fix block insertion UI test #3406

merged 2 commits into from
Apr 21, 2021

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Apr 21, 2021 •
edited
Loading

Gutenberg PR: WordPress/gutenberg#31053

To test:

  1. Execute the command npm run test:e2e:ios:local to run the UI tests
  2. Observe that all of them pass (specifically Gutenberg Editor tests for Block insertion 2)

This can also be verified by triggering the optional UI Tests in the PR checks.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot added [Type] Bug Something isn't working Testing Anything related to automated tests labels Apr 21, 2021
@fluiddot fluiddot requested a review from jd-alexander April 21, 2021 16:08
@fluiddot fluiddot self-assigned this Apr 21, 2021
@fluiddot fluiddot mentioned this pull request Apr 21, 2021
Merged
7 tasks
@peril-wordpress-mobile
Copy link

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

jd-alexander
jd-alexander approved these changes Apr 21, 2021
View reviewed changes
Copy link
Contributor

@jd-alexander jd-alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#31053 (review)

@jd-alexander jd-alexander enabled auto-merge April 21, 2021 18:41
@jd-alexander jd-alexander merged commit 512e42b into develop Apr 21, 2021
@jd-alexander jd-alexander deleted the fix/insertion-ui-test-image-block branch April 21, 2021 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jd-alexander jd-alexander jd-alexander approved these changes

Assignees

@fluiddot fluiddot

Labels
Testing Anything related to automated tests [Type] Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fluiddot @jd-alexander