[pull] master from project-chip:master #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Darwin: Namespace `Download` and `Downloads` * Restyled by clang-format * namespace `UUIDHelper` * fix `gn` build for `MTRUUIDHelper` * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
* Only store data version if the readCache changed * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
* TC-IDM-10.2: Add test for provisional clusters * Restyled by autopep8 * Un-hard-code IDs * Add content control to the init file so we can use the ID * Add some more provisional clusters * Restyled by autopep8 * Restyled by isort * Add in a couple more provisional from main spec * it's nice to add ALL the changes before uploading --------- Co-authored-by: Restyled.io <commits@restyled.io>
* Add log tag for fabric synchrinization * Address review comment
1. Add lightweight CommandSet class to prevent instantiating Shell::Engine, which allows for dynamic command registration, just to create a subshell with a fixed number of subcommands. This slightly reduces the RAM usage. Additionally, the command set automatically prints the help texts if no command or "help" command has been submitted. 2. Add SubShellCommand templatized command handler to remove the boilerplate associated with creating a subshell.
* Remove Interaction Model Engine dependency in WriteHandler * Add test * Add reference * Restyled by whitespace * Restyled by clang-format * Update src/app/WriteHandler.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/WriteHandler.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/WriteHandler.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> --------- Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* [Telink] Add W91 (TLSR9118BDK40D) * [Telink] Fix w91 OTA * [Telink] w91 add pwm pool (#336) * add pwm pool to w91 platform * add pwm pool for w91 platform Signed-off-by: Dmytro Kashkarov <ur6lal@gmail.com> --------- Signed-off-by: Dmytro Kashkarov <ur6lal@gmail.com> * [Telink] disable debug part * [Telink] restyled --------- Signed-off-by: Dmytro Kashkarov <ur6lal@gmail.com> Co-authored-by: Dmytro Kashkarov <114229220+UR6LAL@users.noreply.github.com>
* Add withSourceLocation param to ErrorStr This allows callers to choose at runtime whether or not to include source locations in error strings. * Add tests * Restyled by whitespace * Restyled by clang-format * Remove iostream import This got forgotten from debugging. * Restyled by whitespace --------- Co-authored-by: Restyled.io <commits@restyled.io>
* Use data() instead of begin() in Protocols.cpp The GetProtocolName() function tries to store the result of std::array<T>::begin() in a raw pointer type, but this no longer works on some newer versions of clang, since clang now returns an iterator object. This change fixes this by switching to std::array<T>::data() instead, which always returns a raw pointer. * Restyled by whitespace --------- Co-authored-by: Restyled.io <commits@restyled.io>
…uctor do… (#33473) * Make changes to the window manager class so its static constructor do not call a dynamic allocation before code entry. Limitation with sl memory manager * Restyled by clang-format * implement a destructor for the Timer object to delete the allocated timer --------- Co-authored-by: Restyled.io <commits@restyled.io>
A few fixes here: * Fix MTRDeviceTests to clean up MTRDevice between tests, so each test starts with a known clean slate. * Fix the "are we getting a priming report?" detection in MTRDevice. Relying on reachability state is not correct, because unsolicited reports can mark us reachable even while we are in the middle of a priming report.
* WIP * Update icdm 2.1 cert test * Update ci PICS * Fix ICDM test script * Added unit tests for ICDM 2.1 test script * Fix python linter * fix ci * move staticmethods inside the class * Fix ci for missing function * Fix bit count function
* Add python script for ICDM 3.1 cert test * Delete manual steps * Add script to CI * restyle * remove 3.1 from the manual tests
* Convert TestLevelControlCluster to asyncio Remove ZCLReadAttribute and ZCLSend API use from the level control test TestLevelControlCluster and convert to asyncio. * Convert TestReadBasicAttributes to asyncio Remove ZCLReadAttribute API use from basic information cluster test and convert to use asyncio. * Use SendCommand directly in send_zcl_command Avoid using ZCLSend API instead use SendCommand directly in the send_zcl_command helper function. * Convert TestFailsafe to use asyncio/SendCommand Remove ZCLSend API usage and call SendCommand directly. Also convert the test to a test using asyncio. * Convert TestOnOffCluster to use asyncio/SendCommand Remove ZCLSend API usage and call SendCommand directly. Also convert the test to a test using asyncio. * Drop TestResult helper class The class is no longer required. Test results are tested directly. * Fix send_zcl_command argument formatting * Catch exception more specifically * Fix TestWriteBasicAttributes for all cases It seems TestWriteBasicAttributes did not correctly write the attributes. The broad exception handling seems to have hidden this issue even. Make sure the attributes with the correct value get written, and check for unexpected and expected IM errors in the per-attribute results specifically. * Fix TestFailsafe by catching correct exception * Drop unused import
* [Python] Rename CallAsync to CallAsyncWithCallback CallAsync continuously calls a callback function during the wait for the call. Rename the function to reflect that fact. This frees up CallAsync for an asyncio friendly implementation. * [Python] Implement asyncio variant of CallAsync Call Matter SDK in a asyncio friendly way. During posting of the task onto the CHIP mainloop, it makes sure that the asyncio loop is not blocked. * [Python] Use CallAsync where appropriate * Rename AsyncSimpleCallableHandle to AsyncioCallableHandle * Rename CallAsyncWithCallback to CallAsyncWithCompleteCallback Also add a comment that the function needs to be released by registering a callback and setting the complete event. * Add comments about lock
… flow. (#33470) * [Problem] Authorisation dialogue wasn't disabled when user disabled it from settings [Solution] Put a condition to check if user has authorised it. if not, then dialogue will not be shown. [Test] Tested-by: Lazar Kovacic <kovacic.lazar@gmail.com> * Restyled by google-java-format * Update MatterCommissioningPrompter.java * Restyled by whitespace * Restyled by google-java-format --------- Co-authored-by: osamabb <osamabb@amazon.de> Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Lazar Kovacic <kovacic.lazar@gmail.com>
Co-authored-by: Kwangseob Jeong <mydpp@naver.com>
* [ESP32] Fix build errors when -Wundef compiler flag is enabled * Enable -Wundef for ESP32 * Defining CHIP_SYSTEM_CONFIG_LWIP_PBUF_FROM_CUSTOM_POOL Some platforms do not use the lwip from third_party/lwip and may not have LWIP_PBUF_FROM_CUSTOM_POOLS defined in lwip/opt.h. When building apps with -Wundef cflag enabled, it may fail to find LWIP_PBUF_FROM_CUSTOM_POOLS hence this option. This defaults to LWIP_PBUF_FROM_CUSTOM_POOLS if defined, otherwise 0. * remove includes of <lwip/opt.h> and use <system/SystemConfig.h>
… attributes with Changes Omitted Quality (#33408) * do not cache attribute values for attributes with Changes Omitted Quality * Restyled by whitespace * Restyled by clang-format * manually address feedback that was previously auto-committed * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
…ead-enabled devices (#33472) * [Darwin] MTRDeviceController to limit concurrent subscriptions to Thread-enabled devices * Update src/darwin/Framework/CHIP/MTRDevice.mm Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/darwin/Framework/CHIP/MTRDevice.mm Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/darwin/Framework/CHIP/MTRDevice.mm Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/darwin/Framework/CHIP/MTRDevice.mm Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/darwin/Framework/CHIP/MTRDeviceControllerParameters.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Addressed review comments and added unit test * Update darwin CI workflow to match unit test * Chagned Thread-enabled check to use NetworkCommissioning feature map, and fix affected unit test * Fix compiler warning * Update src/darwin/Framework/CHIP/MTRDeviceControllerStartupParams.mm * Fix affected unit test * Update MTRDevice.mm Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update MTRDeviceControllerParameters.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update MTRPerControllerStorageTests.m Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update MTRPerControllerStorageTests.m Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/darwin/Framework/CHIP/MTRDevice.mm * Update src/darwin/Framework/CHIP/MTRDevice.mm * Update src/darwin/Framework/CHIP/MTRDevice.mm * Update src/darwin/Framework/CHIPTests/MTRPerControllerStorageTests.m * Update src/darwin/Framework/CHIP/MTRDeviceControllerParameters.h * Restyled by whitespace * Restyled by clang-format * Update src/darwin/Framework/CHIP/MTRDevice.mm Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/darwin/Framework/CHIP/MTRDeviceControllerParameters.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/darwin/Framework/CHIP/MTRDeviceControllerParameters.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Updating name --------- Co-authored-by: Justin Wood <woody@apple.com> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> Co-authored-by: Restyled.io <commits@restyled.io>
The idea is to track how long subscriptions took in the past and surface an estimate based on that to the API consumer.
* Run interactive mode by default * Address review comments * allocate make a std::vector<const char*> and pass .data() of that vector to commands.Run()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )