-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESP32: Address -Wundef build errors and enable it for platform #29728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
PR #29728: Size comparison from 0d67568 to 25f603c Decreases (2 builds for efr32)
Full report (78 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
PR #29728: Size comparison from 0d67568 to 481f3f7 Full report (4 builds for cc32xx, mbed, stm32)
|
PR #29728: Size comparison from 0d67568 to 26b5568 Full report (47 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32)
|
Some platforms do not use the lwip from third_party/lwip and may not have LWIP_PBUF_FROM_CUSTOM_POOLS defined in lwip/opt.h. When building apps with -Wundef cflag enabled, it may fail to find LWIP_PBUF_FROM_CUSTOM_POOLS hence this option. This defaults to LWIP_PBUF_FROM_CUSTOM_POOLS if defined, otherwise 0.
PR #29728: Size comparison from 0d67568 to 1161fc5 Decreases (2 builds for efr32)
Full report (80 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
PR #29728: Size comparison from 0d67568 to 5ceb0b5 Increases (2 builds for nrfconnect)
Decreases (2 builds for efr32)
Full report (80 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
bzbarsky-apple
approved these changes
May 15, 2024
wqx6
approved these changes
May 16, 2024
yufengwangca
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29586
-Wundef
and enabled it in ESP32 paltform.Defining CHIP_SYSTEM_CONFIG_LWIP_PBUF_FROM_CUSTOM_POOL
Some platforms do not use the lwip from third_party/lwip and may not have LWIP_PBUF_FROM_CUSTOM_POOLS defined in lwip/opt.h. When building apps with -Wundef cflag enabled, it may fail to find LWIP_PBUF_FROM_CUSTOM_POOLS hence this option. This defaults to LWIP_PBUF_FROM_CUSTOM_POOLS if defined, otherwise 0.