-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Matter SDK to show Authorisation dialog only for account login flow. #33470
Update Matter SDK to show Authorisation dialog only for account login flow. #33470
Conversation
PR #33470: Size comparison from f4e02d4 to bdb295d Full report (9 builds for cc32xx, mbed, nrfconnect, qpg, stm32)
|
PR #33470: Size comparison from f4e02d4 to f46aa42 Full report (4 builds for cc32xx, mbed, stm32)
|
Head branch was pushed to by a user without write access
PR #33470: Size comparison from f4e02d4 to 4340eb7 Decreases (2 builds for efr32)
Full report (52 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32)
|
PR #33470: Size comparison from de95c32 to a02741b Decreases (2 builds for efr32)
Full report (52 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32)
|
@osama10 could you sign the CLA? Robot says "osamabb" did not sign. |
PR #33470: Size comparison from bbd710a to f760969 Decreases (1 build for efr32)
Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
PR #33470: Size comparison from 83d35a3 to 4498a26 Decreases (1 build for efr32)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
[Problem]
Authorisation dialogue should only be shown to user if user enabled it from the secure settings.
matter_show_authorisation_dialog
show the user selection .[Solution]
Check the value of
matter_show_authorisation_dialog
before showing the dialogue. If it's 1 only then we show the dialogue.[Test]
Tested-by: Lazar Kovacic lkovacic@amazon.com