This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add to Cart Form Block > Ensure the editor preview is properly displayed with the Gutenberg plugin disabled #8582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…perly displayed with the Gutenberg plugin disabled.
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +36 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
Aljullu
approved these changes
Mar 1, 2023
There was a problem hiding this comment.
Confirming it fixes the issue, so approving. 🚢
Not a blocker, but I'm wondering if we should try to mimic the frontend markdown in the editor? Ie: we could add classes like wp-element-button to the button, that would ensure the button styles are more similar to the frontend as it will inherit theme styling. Currently, they look quite different:
| Editor (with Pixl) | Frontend (with Pixl) |
|---|---|
 |
 |
|
Thanks for the review 🙌 !
Good idea! I'm opening a separate issue for this. |
dinhtungdu
pushed a commit
that referenced
this pull request
Mar 1, 2023
…yed with the Gutenberg plugin disabled (#8582) * Update the editor styles for the add to cart form button so it is properly displayed with the Gutenberg plugin disabled. * update for the input height. * update the min-height
dinhtungdu
added a commit
that referenced
this pull request
Mar 1, 2023
* Empty commit for release pull request * update 9.7.0 changelog for readme.txt * bump WC versions * 9.7.0 testing notes * Update 970.md * remove 7945 and update 8489 testing note * Remove 8264 testing notes * remove 8482 from testing instructions * Fix alignment of Add to Cart form block (#8578) * update testing zip after cherry-picking 8578 * update changelog * Move testing steps #8438 to experimental section (#8580) * Fix image is not showing at correct position (#8585) Co-authored-by: Tung Du <dinhtungdu@gmail.com> * fix 8478 testing note * fix md error cause the last section hidden * Add to Cart Form Block > Ensure the editor preview is properly displayed with the Gutenberg plugin disabled (#8582) * Update the editor styles for the add to cart form button so it is properly displayed with the Gutenberg plugin disabled. * update for the input height. * update the min-height * update testing zip link * Bumping version strings to new version. --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Tung Du <dinhtungdu@gmail.com> Co-authored-by: Patricia Hillebrandt <patriciahillebrandt@gmail.com> Co-authored-by: Albert Juhé Lluveras <contact@albertjuhe.com> Co-authored-by: kmanijak <karol.manijak@automattic.com> Co-authored-by: Manish Menaria <the.manish.menaria@gmail.com>
13 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures the editor preview for the Add to Cart Button form is displayed correctly while having the Gutenberg plugin disabled: in this particular case, as it turns out, some CSS selectors differ depending on the version of Gutenberg we are on.
Props to @Aljullu for identifying this inconsistency and @imanish003 for the initial flag!
Screenshots
Testing
User Facing Testing
WooCommerce Visibility