Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to cart form block > Ensure the button style in the editor preview matches the frontend #42462

Closed
nefeline opened this issue Mar 1, 2023 · 4 comments
Labels
block: add to cart form team: Kirigami & Origami WC Store Editing (FSE) type: enhancement The issue is a request for an enhancement.

Comments

@nefeline
Copy link
Contributor

nefeline commented Mar 1, 2023

On woocommerce/woocommerce-blocks#8582 (review), @Aljullu made a suggestion to ensure the button style in the editor preview for the add to cart form block matches the frontend, which is a great idea. Porting over the original convo here:

we could add classes like wp-element-button to the button, that would ensure the button styles are more similar to the frontend as it will inherit theme styling. Currently, they look quite different:

Editor (with Pixl) Frontend (with Pixl)
imatge imatge
@nefeline nefeline added block: add to cart form type: enhancement The issue is a request for an enhancement. labels Mar 1, 2023
@imanish003
Copy link
Contributor

There is one more similar issue reported by @albarin i.e. woocommerce/woocommerce-blocks#8587

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

@github-actions github-actions bot added the status: stale Issues that have no had any activity for some time. label May 2, 2023
@gigitux gigitux removed the status: stale Issues that have no had any activity for some time. label Jun 5, 2023
@gigitux
Copy link
Contributor

gigitux commented Jun 5, 2023

I will remove this issue from the scope of Blockified Single Product template. We could fix this in the next iteration of this block!

@nerrad nerrad added the team: Kirigami & Origami WC Store Editing (FSE) label Dec 1, 2023
@ObliviousHarmony ObliviousHarmony transferred this issue from woocommerce/woocommerce-blocks Dec 11, 2023
@Aljullu
Copy link
Contributor

Aljullu commented Dec 12, 2023

This was fixed in woocommerce/woocommerce-blocks#11614.

@Aljullu Aljullu closed this as completed Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
block: add to cart form team: Kirigami & Origami WC Store Editing (FSE) type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

No branches or pull requests

5 participants