This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Fix styles of the Add to Cart form and Product Image Gallery block #8578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aljullu
added
status: needs review
skip-changelog
PRs that you don't want to appear in the changelog.
type: bug
The issue/PR concerns a confirmed bug.
labels
Feb 28, 2023
woocommercebot
requested review from
a team and
thealexandrelara
and removed request for
a team
February 28, 2023 13:30
The release ZIP for this PR is accessible via:
Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
gigitux
approved these changes
Feb 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💪
Should we add the label blocker because we have to add it in the release 9.7.0?
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
Feb 28, 2023
Aljullu
changed the title
Fix alignment of Add to Cart form block
Fix styles of the Add to Cart form and Product Image Gallery block
Feb 28, 2023
4 tasks
Aljullu
added
the
status: blocker
Used on issues or pulls that block work from being released.
label
Feb 28, 2023
Done! cc @dinhtungdu |
@Aljullu I cherry-picked this PR into the release branch ☝🏽. Thank you! |
dinhtungdu
added a commit
that referenced
this pull request
Mar 1, 2023
* Empty commit for release pull request * update 9.7.0 changelog for readme.txt * bump WC versions * 9.7.0 testing notes * Update 970.md * remove 7945 and update 8489 testing note * Remove 8264 testing notes * remove 8482 from testing instructions * Fix alignment of Add to Cart form block (#8578) * update testing zip after cherry-picking 8578 * update changelog * Move testing steps #8438 to experimental section (#8580) * Fix image is not showing at correct position (#8585) Co-authored-by: Tung Du <dinhtungdu@gmail.com> * fix 8478 testing note * fix md error cause the last section hidden * Add to Cart Form Block > Ensure the editor preview is properly displayed with the Gutenberg plugin disabled (#8582) * Update the editor styles for the add to cart form button so it is properly displayed with the Gutenberg plugin disabled. * update for the input height. * update the min-height * update testing zip link * Bumping version strings to new version. --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Tung Du <dinhtungdu@gmail.com> Co-authored-by: Patricia Hillebrandt <patriciahillebrandt@gmail.com> Co-authored-by: Albert Juhé Lluveras <contact@albertjuhe.com> Co-authored-by: kmanijak <karol.manijak@automattic.com> Co-authored-by: Manish Menaria <the.manish.menaria@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
skip-changelog
PRs that you don't want to appear in the changelog.
status: blocker
Used on issues or pulls that block work from being released.
type: bug
The issue/PR concerns a confirmed bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reintroduces the logic to wrap the Single Product template in the frontend. Kudos to @gigitux for suggesting this fix.
This regression was introduced by #8507, which disabled the compatibility layer.
Testing
User Facing Testing
WooCommerce Visibility