Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i18nIgnore] docs: remove old <FileTree> component #1563

Merged
merged 8 commits into from
Mar 4, 2024
Merged

[i18nIgnore] docs: remove old <FileTree> component #1563

merged 8 commits into from
Mar 4, 2024

Conversation

HiDeoo
Copy link
Member

@HiDeoo HiDeoo commented Feb 27, 2024

What kind of changes does this PR include?

  • Changes or translations of Starlight docs site content

Description

This PR is a follow up to #1308 adding a <FileTree> component to Starlight.
This PR removes the old implementation of the <FileTree> component from the docs site.

This PR should be merged after #1308 is merged and should include the [i18nIgnore] tag.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 27, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4254992

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels Feb 27, 2024
@vercel Vercel
Copy link

vercel bot commented Feb 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Mar 4, 2024 9:22am

@HiDeoo HiDeoo mentioned this pull request Feb 27, 2024
Merged
1 task
HiDeoo added 2 commits March 2, 2024 09:46
@HiDeoo
Merge branch 'main' into hd-file-tree-docs
70fd3f6 
* main:
  [ci] format
  [ci] release (withastro#1574)
  Add `<Steps>` component (withastro#1564)
  Add `<FileTree>` component (withastro#1308)
  Add icon support to the `<TabItem>` component (withastro#1568)
  [ci] format
  docs: add Flojoy to showcase (withastro#1571)
  i18n(es): update `components` (withastro#1547)
  i18n(pt-PT): add "manual-setup" page (withastro#1570)
  i18n(zh-cn): Update pages.mdx (withastro#1565)
  Updates internal github actions to the latest versions (withastro#1569)
  [ci] format
  i18n(it): Update pages.mdx & plugins.mdx (withastro#1567)
  [ci] format
  i18n(pt-PT): add "environmental-impact" page (withastro#1561)
  [ci] format
  i18n(zh-cn): Update plugins.mdx (withastro#1566)
@HiDeoo
chore: update lockfile
12f4b45
delucis
delucis approved these changes Mar 2, 2024
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Checked through some of the updated pages side by side with the current ones and not only is everything working nicely, the small tweaks in the new built-in component and icons are all nice improvements.

Looks like there’s a conflict to resolve, but then should be good to go!

docs/package.json
Comment on lines -26 to -34
"@types/hast": "^3.0.3",
"hast-util-from-html": "^2.0.1",
"hast-util-to-string": "^3.0.0",
"hastscript": "^8.0.0",
"pa11y-ci": "^3.0.1",
"rehype": "^13.0.1",
"starlight-links-validator": "^0.5.3",
"start-server-and-test": "^2.0.0",
"unist-util-visit": "^5.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool to see these all removed from our own docs site 🎉

@HiDeoo
Copy link
Member Author

HiDeoo commented Mar 2, 2024 •
edited
Loading

Looks like there’s a conflict to resolve, but then should be good to go!

Ah yeah, this appeared after the update as I started merging some ko-KR translation updates. I'll finish those first and get back to updating this PR after in case there are more of them.

Edit: won't have time to do that today, I unfortunately have to run but will get back to that asap.

@delucis delucis mentioned this pull request Mar 4, 2024
Closed
HiDeoo added 2 commits March 4, 2024 10:16
@HiDeoo
Merge branch 'main' into hd-file-tree-docs
b6a66f1 
* main:
  Translates `fileTree.directory` UI string into simplified Chinese. (withastro#1593)
  [ci] format
  i18n(fr): Update `components.mdx` and `guides/i18n.mdx` (withastro#1575)
  i18n(ko-KR): add `pages.mdx` (withastro#1583)
  i18n(ja): Update components.mdx (withastro#1580)
  i18n(fr): translate `fileTree.directory` UI string (withastro#1585)
  i18n(ko-KR): update `components.mdx` (withastro#1579)
  Translate `fileTree.directory` into Japanese (withastro#1577)
  i18n(ko-KR): update `plugins.mdx` (withastro#1581)
  i18n(ko-KR): update `getting-started.mdx` (withastro#1578)
  i18n(ko-KR): update `i18n.mdx` (withastro#1582)
  i18n(ja): Update i18n.mdx (withastro#1576)
@HiDeoo
[i18nIgnore] docs: remove more old file tree component references
4254992
@HiDeoo HiDeoo merged commit d0ea849 into withastro:main Mar 4, 2024
9 checks passed
@HiDeoo HiDeoo deleted the hd-file-tree-docs branch March 4, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delucis delucis delucis approved these changes

Assignees
No one assigned
Labels
📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HiDeoo @delucis