Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n(ja): Update components.mdx #1580

Merged
merged 5 commits into from
Mar 2, 2024

Conversation

morinokami
Copy link
Contributor

Copy link

changeset-bot bot commented Mar 2, 2024

⚠️ No Changeset found

Latest commit: 1abe912

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Mar 2, 2024 0:07am

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels Mar 2, 2024
Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the translation 🙌

As a non-native speaker, I reviewed this PR using the Docs Translation Review Checklist.

I think 1 sentence is missing in the translation but everything else looks perfect to me 👍

@@ -59,16 +59,24 @@ import { Tabs, TabItem } from '@astrojs/starlight/components';
import { Tabs, TabItem } from '@astrojs/starlight/components';

<Tabs>
<TabItem label="恒星">シリウス、ベガ、ペテルギウス</TabItem>
<TabItem label="衛星">イオ、エウロパ、ガニメデ</TabItem>
<TabItem label="恒星" icon="star">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot add a comment to the line for the description above the example but I think the description is missing the new additional line added to the description:

Use the optional icon attribute to include one of Starlight’s built-in icons next to the label.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've added the missing sentence 🙏

Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@HiDeoo HiDeoo merged commit 36cd40d into withastro:main Mar 2, 2024
9 checks passed
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Mar 4, 2024
* main:
  Translates `fileTree.directory` UI string into simplified Chinese. (withastro#1593)
  [ci] format
  i18n(fr): Update `components.mdx` and `guides/i18n.mdx` (withastro#1575)
  i18n(ko-KR): add `pages.mdx` (withastro#1583)
  i18n(ja): Update components.mdx (withastro#1580)
  i18n(fr): translate `fileTree.directory` UI string (withastro#1585)
  i18n(ko-KR): update `components.mdx` (withastro#1579)
  Translate `fileTree.directory` into Japanese (withastro#1577)
  i18n(ko-KR): update `plugins.mdx` (withastro#1581)
  i18n(ko-KR): update `getting-started.mdx` (withastro#1578)
  i18n(ko-KR): update `i18n.mdx` (withastro#1582)
  i18n(ja): Update i18n.mdx (withastro#1576)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants