-
-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n(ja): Update components.mdx #1580
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the translation 🙌
As a non-native speaker, I reviewed this PR using the Docs Translation Review Checklist.
I think 1 sentence is missing in the translation but everything else looks perfect to me 👍
@@ -59,16 +59,24 @@ import { Tabs, TabItem } from '@astrojs/starlight/components'; | |||
import { Tabs, TabItem } from '@astrojs/starlight/components'; | |||
|
|||
<Tabs> | |||
<TabItem label="恒星">シリウス、ベガ、ペテルギウス</TabItem> | |||
<TabItem label="衛星">イオ、エウロパ、ガニメデ</TabItem> | |||
<TabItem label="恒星" icon="star"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot add a comment to the line for the description above the example but I think the description is missing the new additional line added to the description:
Use the optional
icon
attribute to include one of Starlight’s built-in icons next to the label.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I've added the missing sentence 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix!
* main: Translates `fileTree.directory` UI string into simplified Chinese. (withastro#1593) [ci] format i18n(fr): Update `components.mdx` and `guides/i18n.mdx` (withastro#1575) i18n(ko-KR): add `pages.mdx` (withastro#1583) i18n(ja): Update components.mdx (withastro#1580) i18n(fr): translate `fileTree.directory` UI string (withastro#1585) i18n(ko-KR): update `components.mdx` (withastro#1579) Translate `fileTree.directory` into Japanese (withastro#1577) i18n(ko-KR): update `plugins.mdx` (withastro#1581) i18n(ko-KR): update `getting-started.mdx` (withastro#1578) i18n(ko-KR): update `i18n.mdx` (withastro#1582) i18n(ja): Update i18n.mdx (withastro#1576)
Description
<TabItem>
component #1568<FileTree>
component #1308<Steps>
component #1564