Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n(es): update components #1547

Merged
merged 4 commits into from
Mar 1, 2024
Merged

i18n(es): update components #1547

merged 4 commits into from
Mar 1, 2024

Conversation

dreyfus92
Copy link
Member

@dreyfus92 dreyfus92 commented Feb 22, 2024 •
edited
Loading

Description

  • Closes # N/A
  • What does this PR change? Give us a brief description.
    Updates components

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 22, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: e91442f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Feb 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Mar 1, 2024 3:38pm

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels Feb 22, 2024
Waxer59
Waxer59 approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@Waxer59 Waxer59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

delucis
delucis reviewed Feb 23, 2024
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @dreyfus92! Noticed a couple of details.

docs/src/content/docs/es/guides/components.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/es/guides/components.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/es/guides/components.mdx Outdated Show resolved Hide resolved
kevinzunigacuellar
kevinzunigacuellar reviewed Feb 23, 2024
View reviewed changes
docs/src/content/docs/es/guides/components.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/es/guides/components.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/es/guides/components.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/es/guides/components.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/es/guides/components.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/es/guides/components.mdx Outdated Show resolved Hide resolved
@dreyfus92 @kevinzunigacuellar
Apply suggestions from Chris & Kevin's review
8541b4f 
Co-authored-by: Chris Swithinbank <357379+delucis@users.noreply.github.com>

Co-authored-by: Kevin Zuniga Cuellar <46791833+kevinzunigacuellar@users.noreply.github.com>
@dreyfus92
Copy link
Member Author

Thank you for your reviews @delucis & @kevinzunigacuellar and sorry for the delay 😅

delucis
delucis approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @dreyfus92 — and to everyone for reviewing 🙌

@delucis delucis merged commit 7339027 into withastro:main Mar 1, 2024
8 of 9 checks passed
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Mar 2, 2024
@HiDeoo
Merge branch 'main' into hd-file-tree-docs
70fd3f6 
* main:
  [ci] format
  [ci] release (withastro#1574)
  Add `<Steps>` component (withastro#1564)
  Add `<FileTree>` component (withastro#1308)
  Add icon support to the `<TabItem>` component (withastro#1568)
  [ci] format
  docs: add Flojoy to showcase (withastro#1571)
  i18n(es): update `components` (withastro#1547)
  i18n(pt-PT): add "manual-setup" page (withastro#1570)
  i18n(zh-cn): Update pages.mdx (withastro#1565)
  Updates internal github actions to the latest versions (withastro#1569)
  [ci] format
  i18n(it): Update pages.mdx & plugins.mdx (withastro#1567)
  [ci] format
  i18n(pt-PT): add "environmental-impact" page (withastro#1561)
  [ci] format
  i18n(zh-cn): Update plugins.mdx (withastro#1566)
@dreyfus92 dreyfus92 deleted the updates-90 branch April 10, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinzunigacuellar kevinzunigacuellar kevinzunigacuellar left review comments

@Waxer59 Waxer59 Waxer59 approved these changes

@delucis delucis delucis approved these changes

Assignees
No one assigned
Labels
📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dreyfus92 @delucis @kevinzunigacuellar @Waxer59