Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n(ja) Update under tutorial/6-islands/ #5003

Merged
merged 9 commits into from
Oct 11, 2023

Conversation

piro-hiroki
Copy link
Contributor

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Oct 9, 2023
@netlify
Copy link

netlify bot commented Oct 9, 2023

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit c48ab62
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/6526be794ddeb60009cb2290
😎 Deploy Preview https://deploy-preview-5003--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Comment on lines 71 to 72
<Button href='https://twitter.com/intent/tweet?text=Astroのブログ作成チュートリアルを完走しました!https://docs.astro.build/ をチェックしてみてください!%0A%20%40astrodotbuild'>Twitterで共有</Button>
<Button href='https://www.reddit.com/submit?url=https://docs.astro.build/&title=Astroのブログ作成チュートリアルを完走しました!'>Redditで共有</Button>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering if the translation here is appropriate 🤔 Please point out any discrepancies!

English text

  • Twitter
  • Reddit
    • Just finished learning how to build my first Astro blog!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated Astroのブログ作成チュートリアルを完走しました! => Astroブログの作成方法を学び終えました!

Copy link
Contributor

@morinokami morinokami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一点コメントしました、共有の文言は自分は違和感ないです!

チュートリアルのこの段階でのコードは、[GitHub](https://github.com/withastro/blog-tutorial-demo/tree/unit-6/start)または[StackBlitz](https://stackblitz.com/github/withastro/blog-tutorial-demo/tree/unit-6/start?file=src/pages/index.astro)で確認できます。

あなたのコードを上の例と比較してみてください。また、チュートリアルを始めたばかりであれば、StackBlitzでフォークして、ここからブラウザ上でコーディングを始めてください。

## これから向かう場所
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

この行について、このままでもいいと思うのですが、#5017 では訳を変える前提で議論されているので、同じ内容になるようにここか Discord 上で擦り合わせておいたほうがよさそうです。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

確かにここも「Looking ahead」の訳ですね!
自分としては 5017のmerge後に、文言を合わせる方針で進めようと思います!

Copy link
Contributor

@morinokami morinokami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work 🙌

@yanthomasdev yanthomasdev merged commit 8b2d2dd into withastro:main Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants