Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add share links at the end of the tutorial #4890

Merged
merged 4 commits into from
Oct 2, 2023
Merged

Add share links at the end of the tutorial #4890

merged 4 commits into from
Oct 2, 2023

Conversation

newtoallofthis123
Copy link
Contributor

What kind of changes does this PR include?

  • Changes to the docs site code

Description

This adds two simple buttons to the end of tutorial. No external styles or anything, just imports the standard button component and passing in the share links with the following text URL encoded

Just finished learning how to build my first Astro blog! 

Check it out at https://docs.astro.build/!

Here's a screenshot of the website
image

I took the creative liberty of adding the text to invite the user to share, please do tell me if you want me to change it, but I think it's fun 😄

Congratulations on completing the Astro blog tutorial! Share your achievement with the world and let everyone know you’re an 🧑‍🚀Astronaut now!

Related Issue / Implementation PR

Add Reddit and Twitter Share links at the end of the tutorial
@netlify
Copy link

netlify bot commented Sep 30, 2023

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 55b23e3
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/651a523fb45e51000809470a
😎 Deploy Preview https://deploy-preview-4890--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@dreyfus92
Copy link
Member

dreyfus92 commented Sep 30, 2023

I just noticed we could flex the buttons @newtoallofthis123, we should ask @Otterlord what he thinks about the current orientation of that block and verify if the responsive design works for small screen sizes.

@newtoallofthis123
Copy link
Contributor Author

I checked the responsiveness, it worked well because I just used the already existing responsive <Button /> component. Yeah actually, I just left a comment on his original issue. Let's see what he has to say. Thanks for the review :)

Copy link
Member

@TheOtterlord TheOtterlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for working on this @newtoallofthis123!

On responsiveness, we do use a similar button setup on the getting started page, which wraps the buttons in a div with some flex styling. I've made a suggestion below, with some resulting screenshots. I've also added a small suggestion to the message.

@newtoallofthis123
Copy link
Contributor Author

Hey @TheOtterlord! Just made the changes you recommended :)

Copy link
Member

@TheOtterlord TheOtterlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks great 🙌

@TheOtterlord TheOtterlord linked an issue Oct 2, 2023 that may be closed by this pull request
@TheOtterlord TheOtterlord merged commit d61fcd8 into withastro:main Oct 2, 2023
@newtoallofthis123
Copy link
Contributor Author

Thanks 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Share links at end of tutorial
3 participants