-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add share links at the end of the tutorial #4890
Conversation
Add Reddit and Twitter Share links at the end of the tutorial
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
I just noticed we could flex the buttons @newtoallofthis123, we should ask |
I checked the responsiveness, it worked well because I just used the already existing responsive |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for working on this @newtoallofthis123!
On responsiveness, we do use a similar button setup on the getting started page, which wraps the buttons in a div with some flex styling. I've made a suggestion below, with some resulting screenshots. I've also added a small suggestion to the message.
Hey @TheOtterlord! Just made the changes you recommended :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This looks great 🙌
Thanks 😄 |
What kind of changes does this PR include?
Description
This adds two simple buttons to the end of tutorial. No external styles or anything, just imports the standard button component and passing in the share links with the following text URL encoded
Here's a screenshot of the website

I took the creative liberty of adding the text to invite the user to share, please do tell me if you want me to change it, but I think it's fun 😄
Related Issue / Implementation PR