Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Link Color Issue #4915

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Fix Link Color Issue #4915

merged 2 commits into from
Oct 2, 2023

Conversation

newtoallofthis123
Copy link
Contributor

@newtoallofthis123 newtoallofthis123 commented Oct 2, 2023 •
edited
Loading

What kind of changes does this PR include?

  • Minor content fixes (broken links, typos, etc.)
  • Changes to the docs site code

Description

  • This PR fixes the issue with the links not being clear in light mode in the tutorial share section.

This is the changed output

I am taking part in Hacktoberfest

image

@netlify
Copy link

netlify bot commented Oct 2, 2023 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a496ff8
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/651b0903870473000855cb0e
😎 Deploy Preview https://deploy-preview-4915--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yanthomasdev yanthomasdev added the hacktoberfest-accepted Mark a PR as accepted to contribute towards Hacktoberfest label Oct 2, 2023
yanthomasdev
yanthomasdev approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @newtoallofthis123 🙌

@yanthomasdev yanthomasdev merged commit 3c5d660 into withastro:main Oct 2, 2023
@newtoallofthis123
Copy link
Contributor Author

Thanks 😄

@100gle 100gle mentioned this pull request Oct 3, 2023
Merged
@piro-hiroki piro-hiroki mentioned this pull request Oct 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanthomasdev yanthomasdev yanthomasdev approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Mark a PR as accepted to contribute towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@newtoallofthis123 @yanthomasdev