Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with autoloading modules #792

Merged
merged 1 commit into from
Dec 8, 2022
Merged

Fix issue with autoloading modules #792

merged 1 commit into from
Dec 8, 2022

Conversation

robertalexa
Copy link
Contributor

@LukeTowers This is the code we looked at together.

The fix attempts (and seems to do the job) to fix the autoloading of modules packages.

@what-the-diff
Copy link

what-the-diff bot commented Dec 8, 2022

  • Added a new line to the top of ServiceProvider.php
  • Changed foreach loop in register() method from Config::get('cms.loadModules', []) to $modules variable which was declared on line 26

@LukeTowers LukeTowers added Status: Completed maintenance PRs that fix bugs, are translation changes or make only minor changes labels Dec 8, 2022
@LukeTowers LukeTowers added this to the v1.2.2 milestone Dec 8, 2022
@LukeTowers LukeTowers merged commit d0d066f into wintercms:develop Dec 8, 2022
LukeTowers added a commit that referenced this pull request Dec 8, 2022
@LukeTowers
Merge branch 'develop' into wip/child-theme-autodatasource-caching
fe5f754 
* develop:
  Fix issue with autoloading modules (#792)
  Add support for icon picker (#725)
  Classloader improvements (#779)
  Update Markdown content test
  Improved Ukrainian translation (#766)
  Add AJAX form validation to Snowboard (#777)
  Improve theme scaffolding (#778)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintenance PRs that fix bugs, are translation changes or make only minor changes
Projects
None yet
Milestone
v1.2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@robertalexa @LukeTowers