Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classloader improvements #779

Merged
merged 6 commits into from
Nov 30, 2022
Merged

Classloader improvements #779

merged 6 commits into from
Nov 30, 2022

Conversation

LukeTowers
Copy link
Member

@what-the-diff
Copy link

what-the-diff bot commented Nov 30, 2022

  • The parent::register() method was added to the register methods of all modules.
  • A call to autoloadPackage($namespace, $path) was added in PluginManager's loadPlugin function for each plugin that is loaded by the system module. This allows plugins and their classes to be auto-loaded without having a composer package definition file (composer.json).
  • All module and plugin files are manually registered with Composer's ClassLoader class so they can be auto-loaded when needed during runtime execution of OctoberCMS codebase functions/methods/classes etc...

@LukeTowers LukeTowers added enhancement PRs that implement a new feature or substantial change Status: Testing Needed labels Nov 30, 2022
@LukeTowers LukeTowers added this to the v1.2.2 milestone Nov 30, 2022
@LukeTowers LukeTowers merged commit 0aed0b4 into develop Nov 30, 2022
@LukeTowers LukeTowers deleted the wip/classloader-improvements branch November 30, 2022 03:06
LukeTowers added a commit that referenced this pull request Dec 8, 2022
* develop:
  Fix issue with autoloading modules (#792)
  Add support for icon picker (#725)
  Classloader improvements (#779)
  Update Markdown content test
  Improved Ukrainian translation (#766)
  Add AJAX form validation to Snowboard (#777)
  Improve theme scaffolding (#778)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement PRs that implement a new feature or substantial change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants