Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AJAX form validation #777

Merged
merged 1 commit into from
Nov 28, 2022
Merged

Add AJAX form validation #777

merged 1 commit into from
Nov 28, 2022

Conversation

bennothommo
Copy link
Member

Fixes #628.

This PR adds the Form validation feature to the Snowboard extras that is already documented but was left missing in the original Snowboard implementation.

@bennothommo bennothommo added enhancement PRs that implement a new feature or substantial change needs review Issues/PRs that require a review from a maintainer labels Nov 27, 2022
@bennothommo bennothommo added this to the v1.2.2 milestone Nov 27, 2022
@what-the-diff
Copy link

what-the-diff bot commented Nov 27, 2022

  • Removed the display: none; from [data-request][data-request-validate] [data-validate-for],
    [data-request][data-request-validate] [data. This was causing validation errors to not show up on forms when using AJAX requests.
  • Added a new file called FormValidation which handles showing and hiding of error messages for form fields that are validated via an AJAX request, as well as adding them back into Snowboard's plugin list so they can be used in themes/plugins etc...

@bennothommo bennothommo added Status: Completed and removed needs review Issues/PRs that require a review from a maintainer labels Nov 28, 2022
@bennothommo bennothommo merged commit 1ee713a into develop Nov 28, 2022
@bennothommo bennothommo deleted the wip/js-form-validation branch November 28, 2022 01:37
LukeTowers added a commit that referenced this pull request Dec 8, 2022
@LukeTowers
Merge branch 'develop' into wip/child-theme-autodatasource-caching
fe5f754 
* develop:
  Fix issue with autoloading modules (#792)
  Add support for icon picker (#725)
  Classloader improvements (#779)
  Update Markdown content test
  Improved Ukrainian translation (#766)
  Add AJAX form validation to Snowboard (#777)
  Improve theme scaffolding (#778)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement PRs that implement a new feature or substantial change
Projects
None yet
Milestone
v1.2.2
Development

Successfully merging this pull request may close these issues.

Implement form validation functionality in Snowboard
1 participant
@bennothommo