Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Category Details Screen] Labels On Disabled Buttons Should Be Grayed Out #531

Closed
5 tasks done
rhsalas3 opened this issue Apr 1, 2022 · 1 comment · Fixed by #536
Closed
5 tasks done

[Category Details Screen] Labels On Disabled Buttons Should Be Grayed Out #531

rhsalas3 opened this issue Apr 1, 2022 · 1 comment · Fixed by #536

Comments

@rhsalas3
Copy link
Contributor

rhsalas3 commented Apr 1, 2022

Description:

Currently on the Category Details screen, for a button that is disabled, the background of the button is properly grayed out but the label (and switch for the 'Show Category' button) are not. This makes it a bit more difficult for users to tell the difference between a button that is tappable and one that is disabled. We should update the buttons to look more like designs, or at least how they were prior to the screen's layout changes.

This issue ticket is related to #485 and is caused by changes made in PR #527 . Notes about the expected behavior are in the PR conversation, and original AC that define expected behavior of the buttons for specific categories can be found in the conversation of issue ticket #465 .

Acceptance Criteria:

  • Labels on disabled buttons of the Category Details screen should be grayed out.
  • Categories with disabled buttons:
    • For 'My Sayings' -> the 'Remove Category', and 'Show Category' buttons should be disabled
    • For 'Recents' -> the 'Edit Phrases' button should be disabled
    • For '123' -> the 'Edit Phrases' button should be disabled

Design:

Example of a disabled button ('Remove Category') from the Category Details screen.
https://www.figma.com/file/mNrwUygVhTmuWnKNHHkenR/Vocable---Current?node-id=3641%3A27468

Screenshot(s):

CategoryDetailsScreen_disabledButtons_notObviouslyGrayedOut_comparedToPreviousVersion

@rhsalas3
Copy link
Contributor Author

rhsalas3 commented Apr 4, 2022

Tested on PR branch and this issue has been fixed.

PR #536

jsmorgan42 added a commit that referenced this issue Apr 5, 2022
@rhsalas3 rhsalas3 mentioned this issue Apr 19, 2022
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants