Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#531 | Fixing Disabled Color State #536

Merged
merged 2 commits into from
Apr 5, 2022

Conversation

jsmorgan42
Copy link
Contributor

@jsmorgan42 jsmorgan42 commented Apr 4, 2022

closes #531

Description of Work

Fixes a bug where title text color of the new configured cells weren't changing to a lower alpha color for its disabled state. The issue was resolved by not setting the foreground color for the attributed title & manually setting the title color after setting the attributed text in GazeableButton

Before:

After:


@rhsalas3
Copy link
Contributor

rhsalas3 commented Apr 4, 2022

Tested on this PR branch and the changes look good! The buttons and their labels look to be disabled, as expected.

Copy link
Collaborator

@Clstroud Clstroud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love how concise this fix actually ended up being. Nice job 💯

@jsmorgan42 jsmorgan42 merged commit f3fba64 into develop Apr 5, 2022
@jsmorgan42 jsmorgan42 deleted the feature/531-disabled-labels-fix branch April 5, 2022 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Category Details Screen] Labels On Disabled Buttons Should Be Grayed Out
3 participants