Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Edit Category Screen Styling #485

Closed
Ly-Kyli opened this issue Mar 22, 2022 · 1 comment · Fixed by #527
Closed

Update Edit Category Screen Styling #485

Ly-Kyli opened this issue Mar 22, 2022 · 1 comment · Fixed by #527
Assignees
@moyerr
Labels
Settings Test verified v1.4

Comments

@Ly-Kyli
Copy link

Ly-Kyli commented Mar 22, 2022 •
edited
Loading

Acceptance Criteria:

  1. Pencil Icon is now replaced with the rename category button
  2. "Show" is renamed as "Show Category"
  3. Edit Phrases styling updated to match other buttons (currently text is smaller than other buttons on this screen)
  4. Remove Category button color and styling updated
  5. Margins and padding updated to match figma design

Design:
Tablet Landscape
Tablet Portrait
Iphone Landscape
Iphone Portrait
@Ly-Kyli Ly-Kyli changed the title Update "Remove Category" Button Styling Update Edit Category Screen Styling Mar 22, 2022
This was referenced Mar 28, 2022
Merged
Merged
moyerr added a commit that referenced this issue Mar 28, 2022
@moyerr
#485 | Add navigation title and update edit title cell
b990b47
moyerr added a commit that referenced this issue Mar 29, 2022
@moyerr
#485 | Hook up the configurations for the rest of the Edit Category c…
bb35358 
…ells
moyerr added a commit that referenced this issue Mar 29, 2022
@moyerr
#485 | Add navigation title and update edit title cell
371c9d6
moyerr added a commit that referenced this issue Mar 29, 2022
@moyerr
#485 | Hook up the configurations for the rest of the Edit Category c…
a609ff2 
…ells
moyerr added a commit that referenced this issue Mar 30, 2022
@moyerr
#485 | Add the 􀈑 icon to the button
95b4207
moyerr added a commit that referenced this issue Mar 30, 2022
@moyerr
#485 | Add navigation title and update edit title cell
5c8e619
moyerr added a commit that referenced this issue Mar 30, 2022
@moyerr
#485 | Hook up the configurations for the rest of the Edit Category c…
34e025e 
…ells
moyerr added a commit that referenced this issue Mar 30, 2022
@moyerr
#485 | Add the 􀈑 icon to the button
68c16c6
@moyerr moyerr mentioned this issue Mar 30, 2022
Merged
moyerr added a commit that referenced this issue Mar 30, 2022
@moyerr
#485 | Update design for the Remove Category confirmation alert
9a74e08
moyerr added a commit that referenced this issue Mar 30, 2022
@moyerr
#485 | Update localized strings
3f83519
moyerr added a commit that referenced this issue Mar 31, 2022
@moyerr
#485 | Add RtL layout support for trash icon in button
ee0d1f8
@rhsalas3 rhsalas3 mentioned this issue Apr 1, 2022
Closed
5 tasks
@rhsalas3
Copy link
Contributor

rhsalas3 commented Apr 1, 2022

@CananArikan and I tested the changes on the PR branch for this ticket (#527 ). The screen matches designs and meets the ACs, and continues to function as expected. So this issue looks good to go.

We did have some feedback about the way the buttons look now, when they're in the disabled state. This was written up as a new issue ticket, #531 .

@rhsalas3 rhsalas3 mentioned this issue Apr 19, 2022
Open
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@moyerr moyerr

Labels
Settings Test verified v1.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

485 | Edit Category Details screen design updates 📝 🎨 willowtreeapps/vocable-ios
4 participants
@moyerr @Ly-Kyli @rhsalas3 @SashankPatel