-
-
Notifications
You must be signed in to change notification settings - Fork 935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cip42 capable tx parser #897
Conversation
🦋 Changeset detectedLatest commit: 0d3e5d8 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Someone is attempting to deploy a commit to the wagmi Team on Vercel. A member of the Team first needs to authorize it. |
Codecov Report
@@ Coverage Diff @@
## main #897 +/- ##
===========================================
- Coverage 99.78% 86.91% -12.88%
===========================================
Files 260 245 -15
Lines 24998 24412 -586
Branches 1958 1344 -614
===========================================
- Hits 24945 21218 -3727
- Misses 50 3160 +3110
- Partials 3 34 +31
|
b3ea893
to
6f8846e
Compare
bit confused as to why its saying there is less coverage, its reporting the original parse Transaction Errors are not being tested yet there are tests for them that pass |
* chore: update abitype * chore: chore changeset * chore: downgrade pnpm
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* feat: add support for resolving ens addresses using coinType * docs: update the docs to include examples for using coinType * refactor: address pr comments and merge ABIs * refactor * chore: changeset * refactor: alphabetize * docs: coinType type --------- Co-authored-by: moxey.eth <jakemoxey@gmail.com>
Ensure the [!code focus] is applied to the `to` param for the `to` param section of the docs.
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* prevent scientific notation bug for large integers when decimals == 0 * add parseUnits changeset * better comparison * slice for consistency * refactor --------- Co-authored-by: moxey.eth <jakemoxey@gmail.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
fix: wrong mapping of JSON RPC method for watchAsset The docs stated the JSON RPC method was `eth_switchEthereumChain` but it should be `wallet_watchAsset`.
…dError` (wevm#941) fix: capture unsupported error signatures
* fix: Rename the and types with the appropriate file prefixes * ref: add migration path for deprecated types * Update honest-grapes-leave.md * Update index.ts * Update contract.ts * Update index.ts * Update public.ts --------- Co-authored-by: jxom <jakemoxey@gmail.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
fix type in import
* docs: update run test as per wevm#996 * Update CONTRIBUTING.md --------- Co-authored-by: jxom <jakemoxey@gmail.com>
* fix estimateContractGas' error docsPath * chore: update snapshots --------- Co-authored-by: norswap <norswap@gmail.com>
* docs: add Ethereum Provider section * Update typescript.md * Update typescript.md --------- Co-authored-by: jxom <jakemoxey@gmail.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…#886) * feat: optimism transaction receipt formatter * refactor: restructure * chore: tests
…or` (wevm#1008) * match already known * Create little-ravens-warn.md --------- Co-authored-by: jxom <jakemoxey@gmail.com>
* feat: optimism transaction receipt formatter * refactor: restructure * feat: chain fees config * chore: changeset * chore: update test * chore: impl * refactor: cleanup formatters & serializers types * chore: fix * refactor * chore: snapshots * Update sweet-lemons-explain.md * Update sweet-lemons-explain.md * refactor * refactor * refactor
…chContractEvent` (wevm#1012) * Support eth_subscribe in watchContractEvent * Complete test suite for watchContractEvent * Support eth_subscribe in watchEvent and add tests * Update docs * chore: add tests * chore: update docs --------- Co-authored-by: Simone <simone@nemo.ventures>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* refactor: use const type parameters * chore: ts version * chore: changeset * chore: lint errors * chore: format * test: types * chore: update * refactor: remove Narrow * docs: fix * test: dynamic multicall types * chore: fix snapshot --------- Co-authored-by: tmm <tmm@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* refactor: use const type parameters * chore: ts version * chore: changeset * chore: lint errors * chore: format * test: types * chore: update * refactor: remove Narrow * docs: fix * test: dynamic multicall types * chore: fix snapshot * chore: snapshot * chore: types * chore: updates --------- Co-authored-by: tmm <tmm@users.noreply.github.com>
closing for #1035 |
Following on from #755 it becomes evident that a parser capable of handling cip42 transactions is need as the default will simple error out. This parser follows the same patter as serializer first checking if the transaction is the right kind and if not deferring to the default
parseTransaction
function.PR-Codex overview
This PR updates the viem library to version 1.6.1.
Detailed summary
parseTransactionCelo
function for parsing serialized transactions