Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update outdated testing instructions #998

Merged
merged 2 commits into from
Aug 8, 2023
Merged

Conversation

KipCrossing
Copy link
Contributor

@KipCrossing KipCrossing commented Aug 8, 2023

In this PR, the section Running the test suite is updated:

  • ANVIL_FORK_URL is changed to VITE_ANVIL_FORK_URL to match above
  • clarity the the RPC service provider should be mainnet
  • Remove pnpm anvil step. It doesn't seem to be required
  • Add instructions to re-run with f in case it fails the first time.

Still waiting for #996 to be concluded tho.


PR-Codex overview

Detailed summary

  • Updated the variable name ANVIL_FORK_URL to VITE_ANVIL_FORK_URL in .github/CONTRIBUTING.md.
  • Added a note about running tests in watch mode using pnpm test.
  • Added a note about rerunning failed tests by pressing f.
  • Added a note about the importance of adding test cases for new features or bug fixes.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Aug 8, 2023

⚠️ No Changeset found

Latest commit: 89478a3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Aug 8, 2023

@KipCrossing is attempting to deploy a commit to the wagmi Team on Vercel.

A member of the Team first needs to authorize it.

@KipCrossing KipCrossing marked this pull request as draft August 8, 2023 12:01
@jxom jxom marked this pull request as ready for review August 8, 2023 12:44
@jxom jxom merged commit 77fe589 into wevm:main Aug 8, 2023
aaronmgdr pushed a commit to celo-org/viem that referenced this pull request Aug 18, 2023
* docs: update run test  as per wevm#996

* Update CONTRIBUTING.md

---------

Co-authored-by: jxom <jakemoxey@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants