Support eth_subscribe over websockets for watchEvent and watchContractEvent #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: +2.53 kB (+1%) Total Size: 319 kB
ℹ️ View Unchanged
|
Codecov Report
@@ Coverage Diff @@
## main #1012 +/- ##
==========================================
+ Coverage 94.85% 94.92% +0.06%
==========================================
Files 262 262
Lines 25798 26033 +235
Branches 1823 1855 +32
==========================================
+ Hits 24471 24711 +240
+ Misses 1315 1309 -6
- Partials 12 13 +1
|
cc33614 to
aa84445
Compare
aaronmgdr
pushed a commit
to celo-org/viem
that referenced
this pull request
Aug 18, 2023
…chContractEvent` (wevm#1012) * Support eth_subscribe in watchContractEvent * Complete test suite for watchContractEvent * Support eth_subscribe in watchEvent and add tests * Update docs * chore: add tests * chore: update docs --------- Co-authored-by: Simone <simone@nemo.ventures>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dupe of #985
PR-Codex overview
Detailed summary:
polloption to thewatchEventandwatchContractEventfunctions.polloption allows clients to use a polling mechanism to check for new logs instead of a WebSocket subscription.pollisfalsefor WebSocket clients andtruefor non-WebSocket clients.pollistrueand the RPC Provider supportseth_newFilter, the functions will calleth_newFilterto create a filter andeth_getFilterChangeson a polling interval to get new logs.pollistrueand the RPC Provider does not supporteth_newFilter, the functions will calleth_getLogsfor each block between the polling interval to get new logs.pollisfalseand the WebSocket Transport is used, the functions will use a WebSocket subscription viaeth_subscribeand the "logs" event to get new logs.pollingIntervaloption to specify the polling frequency in milliseconds. The default value is the client'spollingIntervalconfig.watchEventandwatchContractEventto include information about the newpolloption and the different behaviors based on the RPC Provider support and WebSocket Transport usage.