Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update BSM2-P Costing #1468

Merged
merged 26 commits into from
Sep 9, 2024
Merged

Update BSM2-P Costing #1468

merged 26 commits into from
Sep 9, 2024

Conversation

MarcusHolly
Copy link
Contributor

Fixes/Resolves:

Tries to resolve issues with costing in the BSM2 P-extension flowsheet by adjusting scaling and using the interval initializer

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@MarcusHolly MarcusHolly self-assigned this Jul 19, 2024
@lbianchi-lbl lbianchi-lbl added Priority:High High Priority Issue or PR costing iedo labels Jul 25, 2024
@lbianchi-lbl lbianchi-lbl mentioned this pull request Jul 25, 2024
Closed
@ksbeattie
Copy link
Contributor

Wait for #1469 to be merged

@MarcusHolly MarcusHolly mentioned this pull request Aug 30, 2024
Merged
@MarcusHolly MarcusHolly marked this pull request as ready for review September 9, 2024 12:48
adam-a-a
adam-a-a approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@adam-a-a adam-a-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks to you @MarcusHolly and @luohezhiming !

agarciadiego
agarciadiego approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@agarciadiego agarciadiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lbianchi-lbl lbianchi-lbl merged commit e95f0a7 into watertap-org:main Sep 9, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adam-a-a adam-a-a adam-a-a approved these changes

@agarciadiego agarciadiego agarciadiego approved these changes

@luohezhiming luohezhiming Awaiting requested review from luohezhiming

Assignees

@MarcusHolly MarcusHolly

Labels
costing iedo Priority:High High Priority Issue or PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MarcusHolly @ksbeattie @adam-a-a @agarciadiego @lbianchi-lbl