Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise modified ADM1 rxns and BSM2-P flowsheet #1467

Closed
wants to merge 86 commits into from
Closed

Revise modified ADM1 rxns and BSM2-P flowsheet #1467

wants to merge 86 commits into from

Conversation

adam-a-a
Copy link
Contributor

Fixes/Resolves:

Summary/Motivation:

The extended BSM2-P flowsheet still has stability issues. Here, I check if adjustments to expressions in modified ADM1 will improve BSM2-P stability after the addition of costing, which seems to become more unstable and cannot pass tests consistently after that point.

Changes proposed in this PR:

  • add epsilon value to denominators of reaction rate expressions in modified ADM1

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

MarcusHolly added 30 commits June 13, 2024 00:20
@MarcusHolly
Finish implementation of adm1/asm2d translator
af1dc9a
@MarcusHolly
Resolve inconsistent unit errors
8318db2
@MarcusHolly
Update test file
c0b8329
@MarcusHolly
Remove completed to-do item
b1273c4
@MarcusHolly
Merge branch 'main' into new_adm1_asm2d_interface
df81af7
@MarcusHolly
Add Soraya's scaling improvements
6b6a448
@MarcusHolly
Address minor formatting issues
66a7c44
@MarcusHolly
Add BSM2 flowsheet w/new translator
07ff096
@MarcusHolly
New flowsheet solving with Bio_P=True
8133b7a
@MarcusHolly
Minor improvements to BSM2
906fb13
@MarcusHolly
BioP=True solves & BioP=False fails
4953299
@MarcusHolly
Update translator documentation
f5ee78f
@MarcusHolly
Correct imports in test file
49ce16c
@MarcusHolly
Try automating scaling
5731370
@MarcusHolly
Test autoscaling function
22c3091
@MarcusHolly
Merge branch 'main' into new_adm1_asm2d_interface
98978a0
@MarcusHolly
Update AD initialization
4159a92
@MarcusHolly
Delete new files and update old files
22fd6a9
@MarcusHolly
Merge branch 'main' into new_adm1_asm2d_interface
321b16e
@MarcusHolly
Add Chenyu's versions of solved flowsheets
a205a7a
@MarcusHolly
Clean up flowsheets
87ccc2f
@MarcusHolly
Update test solutions
7150b66
@MarcusHolly
Minor cleanup
b7b2c17
@MarcusHolly
Add scaling factor that was accidentally deleted
d637ff4
@MarcusHolly
Add bac 2nd conservation test
33b52e3
@MarcusHolly
Merge branch 'main' into new_adm1_asm2d_interface
9125cda
@MarcusHolly
Address some electroN-P issues
4617c92
@MarcusHolly
Add scaling function to BSM2 ui file
c7b9d56
@MarcusHolly
Update test files
a95b8e8
@MarcusHolly
address Pylint issue
07ffba0
MarcusHolly and others added 19 commits July 11, 2024 16:06
@MarcusHolly
Address pylint issue
3ea1f3c
@MarcusHolly
Delete tests for bio_P=True
c719fbe
@MarcusHolly
Have GUI use bio_P=False instead of bio_P=True
46071a5
@MarcusHolly
Put common translator parameters inside of ADM1 reaction package
c6700b5
@MarcusHolly
Use watertap solver instead of IDAES
9bc5840
@MarcusHolly
Update tests for bio_P=True and bio_P=False
b3cd2bf
@MarcusHolly
Add config option for bio_P into GUI
95a6f9b
@MarcusHolly
Address pylint issues
f8476c2
@MarcusHolly
Try to resolve remaining test failures
cbbfe6f
@MarcusHolly
Add watertap get_solver to test file
bb95f8d
@MarcusHolly
Get rid of config option in BSM2-P GUI
cc3f243
@MarcusHolly
Try to resolve GUI issue
b63ce95
@MarcusHolly
Minor change to flowsheet scaling
4dc04b3
@MarcusHolly
Add require_idaes_solver to BSM2-P GUI
4e8d9ed
@luohezhiming
Resolve solving issue
0729d39
@luohezhiming
Merge branch 'new_adm1_asm2d_interface' of https://github.com/MarcusH…
cc61553 
…olly/watertap into new_adm1_asm2d_interface
@MarcusHolly
Comment out everything related to costing
a7bdd21
@MarcusHolly
Merge branch 'new_adm1_asm2d_interface' of https://github.com/MarcusH…
77bd768 
…olly/watertap into new_adm1_asm2d_interface
@adam-a-a
replace eps values with parameter and add eps to denominator of suspe…
0f3817c 
…cted problematic term
@adam-a-a adam-a-a marked this pull request as draft July 17, 2024 20:36
@adam-a-a adam-a-a mentioned this pull request Jul 17, 2024
Merged
@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Jul 18, 2024
@lbianchi-lbl
Copy link
Contributor

This is one of the attempts to troubleshoot the BSM2-P flowsheet, together with #1468 and #1469.

@ksbeattie
Copy link
Contributor

Replaced by #1468

@ksbeattie ksbeattie closed this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@adam-a-a adam-a-a

@MarcusHolly MarcusHolly

Labels
Priority:Normal Normal Priority Issue or PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@adam-a-a @lbianchi-lbl @ksbeattie @MarcusHolly @luohezhiming