-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance linting #95
Enhance linting #95
Conversation
Failing pipeline is addressed with vivid-planet/comet#1540 |
I'd prefer ignoring block-meta.json over having Prettier as a dependency in |
Done with 85de1c1 I had to copy .gitignore into .prettierignore because prettier is yet to support multiple ignore files (prettier/prettier#8048) |
Overall I'm not 100% happy with the solution :( but it is better than before, because we did e.g. not lint CI/CD files IDE support is not great when ignoring all microservices and the difference between CLI and IDE (for ignoring files) is far from ideal |
Why?
I'd say we copy all existing .gitignore into .prettierignore and add a comment to remove them once we upgrade to Prettier v3 |
a4c36fb
to
d6622cb
Compare
Done |
d6622cb
to
6c5ea47
Compare
@kaufmo please review |
@fraxachun @nsams please review |
#95 (comment) Fixes the "bad IDE support" by allowing allowing prettier in IDE for api/admin/site/create-app but executing the cli-check only for root-files.
Adopt enhancements from vivid-planet/comet-starter#95 for core.
Following problems are addressed here:
However, this has bad IDE support as we have a prettierignore with (api/admin/site/create-app). This can be resolved by either copying the .gitignore into .prettierignore and removing the ignore patterns or by updating to prettier 3 (which ignores all files from .gitignore by default, https://prettier.io/blog/2023/07/05/3.0.0.html#cli)