Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Prettier in IDE for microservices #169

Merged
merged 3 commits into from
Feb 28, 2024
Merged

Allow Prettier in IDE for microservices #169

merged 3 commits into from
Feb 28, 2024

Conversation

fraxachun
Copy link
Contributor

#95 (comment)

Fixes the "bad IDE support" by allowing allowing prettier in IDE for api/admin/site/create-app but executing the cli-check only for root-files.

dkarnutsch
dkarnutsch requested changes Feb 26, 2024
View reviewed changes
nsams
nsams reviewed Feb 26, 2024
View reviewed changes
johnnyomair
johnnyomair approved these changes Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@johnnyomair johnnyomair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally, thanks!

@johnnyomair johnnyomair changed the title Allow prettier in IDE for api/admin/site Allow Prettier in IDE for microservices Feb 28, 2024
@johnnyomair
Copy link
Collaborator

@dkarnutsch please review again, thanks!

@thomasdax98 thomasdax98 merged commit 65d2dea into main Feb 28, 2024
2 checks passed
@thomasdax98 thomasdax98 deleted the prettier branch February 28, 2024 09:17
@max-debug022 max-debug022 mentioned this pull request Apr 15, 2024
Merged
johnnyomair pushed a commit that referenced this pull request Apr 16, 2024
@max-debug022
@comet/create-app remove-site: Fix script after changes in package.js…
d6252fe 
…on (#221)

Fixes bug caused by changes in #169, where the lint:root script was
modified, resulting in the deletion of the script in the package.json by
the remove-site script, leading the program to crash.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsams nsams nsams approved these changes

@kaufmo kaufmo kaufmo approved these changes

@dkarnutsch dkarnutsch dkarnutsch approved these changes

@thomasdax98 thomasdax98 thomasdax98 approved these changes

@johnnyomair johnnyomair johnnyomair approved these changes

Assignees

@fraxachun fraxachun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@fraxachun @johnnyomair @nsams @kaufmo @dkarnutsch @thomasdax98