-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Following problems are addressed here: - Lint-Staged should match actual lint config - Linting project root did not take into account subfolders (i.e. .gitlab ci) due to misconfigured glob pattern - Yaml files did not get linted (e.g. helm files) due to missing extension - Files outside of folder "src" from microservices (api/admin/site) did not get linted as eslint did only get executed on "src" folder (e.g. next-config or readme) - Harmonize lint calls with run-p However, this has bad IDE support as we have a prettierignore with (api/admin/site/create-app). This can be resolved by either copying the .gitignore into .prettierignore and removing the ignore patterns or by updating to prettier 3 (which ignores all files from .gitignore by default, https://prettier.io/blog/2023/07/05/3.0.0.html#cli)
- Loading branch information
1 parent
2abe799
commit 5f76a4b
Showing
18 changed files
with
558 additions
and
45 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,8 @@ | ||
.docker-sync | ||
*.unison.node_modules.* | ||
.idea | ||
|
||
node_modules | ||
.yarn | ||
.npm | ||
.babelCache | ||
schema.graphql | ||
comet-lang | ||
/api/uploads | ||
|
||
.env.local | ||
.env.secrets | ||
lang |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,17 @@ | ||
# Copy from .gitignore, remove once prettier v3 is in use | ||
.idea | ||
|
||
.npm | ||
.babelCache | ||
|
||
.env.local | ||
.env.secrets | ||
|
||
# Go Templates can not be formatted with prettier (https://github.com/prettier/prettier/issues/6517) | ||
chart/*/templates/* | ||
|
||
# Microservices are checked by each microservice on its own | ||
admin/ | ||
api/ | ||
site/ | ||
schema.graphql | ||
lang/ | ||
create-app/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,18 @@ | ||
.env | ||
.env.local | ||
.env.secrets | ||
|
||
/node_modules | ||
|
||
/build | ||
|
||
/lang/ | ||
/lang-compiled/ | ||
/lang-extracted/ | ||
|
||
fragmentTypes.json | ||
/schema.* | ||
|
||
**/*.generated.ts | ||
/block-meta.json | ||
src/comet-config.json |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,25 @@ | ||
# Copy from .gitignore until prettier v3 is in use | ||
.env | ||
.env.local | ||
.env.secrets | ||
|
||
/node_modules | ||
|
||
/build | ||
|
||
/lang/ | ||
/lang-compiled/ | ||
/lang-extracted/ | ||
|
||
fragmentTypes.json | ||
/schema.* | ||
|
||
**/*.generated.ts | ||
/block-meta.json | ||
/comet-config.json | ||
|
||
package-lock.json | ||
.gitignore | ||
*.lock | ||
*.gql | ||
*.dist | ||
src/fragmentTypes.json | ||
src/graphql.generated.ts |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,50 @@ | ||
# Copy from .gitignore until prettier v3 is in use | ||
# compiled output | ||
/dist | ||
|
||
/node_modules | ||
.env | ||
.env.local | ||
.env.secrets | ||
|
||
# Logs | ||
logs | ||
*.log | ||
npm-debug.log* | ||
yarn-debug.log* | ||
yarn-error.log* | ||
lerna-debug.log* | ||
|
||
# OS | ||
.DS_Store | ||
|
||
# Tests | ||
/coverage | ||
/.nyc_output | ||
junit.xml | ||
|
||
# IDEs and editors | ||
/.idea | ||
.project | ||
.classpath | ||
.c9/ | ||
*.launch | ||
.settings/ | ||
*.sublime-workspace | ||
|
||
# IDE - VSCode | ||
.vscode/* | ||
!.vscode/settings.json | ||
!.vscode/tasks.json | ||
!.vscode/launch.json | ||
!.vscode/extensions.json | ||
|
||
# Uploads | ||
/uploads | ||
|
||
package-lock.json | ||
.gitignore | ||
*.lock | ||
*.gql | ||
*.dist | ||
uploads/ | ||
block-meta.json |
Oops, something went wrong.