tablet query engine: introduce -enable-consolidator-replicas #5862
+112
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This diff creates the possibility to start a tablet with "-enable-consolidator=false -enable-consolidator-replicas" so that query consolidation is enabled only for non-master instance types. This allows using the consolidator while keeping the agreement that OLTP reads from master have read-committed consistency while replicas have inconsistent reads. See vitessio#4058 Signed-off-by: David Weitzman <dweitzman@pinterest.com>
f83e152 to
8056e74
Compare
sougou
approved these changes
Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff creates the possibility to start a tablet with
"-enable-consolidator=false -enable-consolidator-replicas" so
that query consolidation is enabled only for non-master instance
types.
This allows using the consolidator while keeping the agreement that
OLTP reads from master have read-committed consistency, while replicas
have inconsistent reads.
See #4058