This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
6.0 Slack vitess release merge (w/consul 1.5.1, no k3s) #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Remove unused code
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
… tablet is written to topo Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
PromoteSlaveWhenCaughtUp RPC Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
…th current master Signed-off-by: deepthi <deepthi@planetscale.com>
vtctld: proxy must update target URLs
Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Now that we allow fractional seconds, let's use this as a standardized unit. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com> Signed-off-by: deepthi <deepthi@planetscale.com>
This flag didn't previously exist, but there are users that want to fine tune this setting. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Fixes vitessio#6264 Fixes vitessio#6285 Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
…s to floats Signed-off-by: Rohit Nayak <rohit@planetscale.com>
backport vitessio#6205 to 6.0 release branch
backport vitessio#6224 to 6.0 release branch
backport vitessio#6250 to 6.0 release branch
backport vitessio#6299 to 6.0 release branch
backport vitessio#6317 to 6.0 release branch
backport vitessio#6308 to 6.0 release branch
Backport vitessio#6270 to 6.0 release branch
…ar-clashes Make sure to protect insert lookup queries from bind var name clashes (6.0)
c486e35 to
3ba31fd
Compare
Signed-off-by: Andrew Mason <amason@slack-corp.com>
3ba31fd to
f6f2cfa
Compare
Signed-off-by: Andrew Mason <amason@slack-corp.com>
This was referenced Jun 23, 2020
setassociative
approved these changes
Jun 25, 2020
There was a problem hiding this comment.
This all seems fine. Some things to call out though:
-
heartbeat: create table only on master with binlog ON, use app_user not dba_user vitessio/vitess#6053 I think in the cases where we see a failover that leaves one tablet thinking it's still the primary this could generate ErrantTxns on the failed primary. Also, to be clear this should be safe; it's only the alerts I've got in mind as a concern.
-
Improve Update and Delete Query Routing for IN Clause vitessio/vitess#6116 This is great, we should watch for decreased scatters before/after deploy; probably wouldn't hurt to smoke test this either
-
use topo method for parsing target string on set target method call vitessio/vitess#6096 I would not be super surprised if we see some changes to reported keyspace in agenda
And the following sorta worry me only in that the are large / complex with minimal discussion (and I don't know the codebase well enough to grok them).. but presumably it should be somewhat obvious if they fail 😓
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Git Shenanigans
To avoid reverting back to consul 1.4.5, but also without needing to go all the way to 1.8.0, we needed to pull out the k8s topo bits, which were done in the following commits:
Slack Changes
EnsureVSchemaandGetOrCreateShardto only rebuild SrvVSchema in the single cell 🎉handleOtherUpstream Changes
PLANNED REPARENT FIXES
UndoDemoteMaster, thanks Deepthi!query
SHOW FULL COLUMNSon unqualified tablesDEFAULThandleUsefrom executenilinstructionsSHOW INDEXESandEXTENDEDtopo
WatchSrvVSchemaandGetSrvKeyspaceNamesvttablet
NewDBConnNoPool🎉USEandDATABASE()fixesvtgate (some of the things under
queryare arguablyvtgate🤷♂️ )vtctld
--skip-verifytoCopySchemaShard-proxy_tabletsto vtctld-forceflag toDeleteCellInfoApplyVSchemavrep
backups
xtrabackup preparephasemetrics
session variables
setstatement parsersetUDV implementationsolap
use keyspace[shard]select database()in OLAP mode (#6200) vitessio/vitess#6205 fixes panic withselect database()in olap mode (backported in backport #6205 to 6.0 release branch vitessio/vitess#6318)heartbeat
vtexplain
java
Misc
MarshalJSONimplementations