vstreamer: send immediate GTID on "current" #5891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the current position is requested as start for vstream, it will be good to send the actual starting GTID as a separate event before streaming the rest. This is particularly useful for messager because it needs to know its current position from the beginning in order to determine which events to skip w.r.t to poller position. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
deepthi
reviewed
Mar 9, 2020
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
deepthi
approved these changes
Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the current position is requested as start for vstream, it will
be good to send the actual starting GTID as a separate event before
streaming the rest.
This is particularly useful for messager because it needs to know
its current position from the beginning in order to determine which
events to skip w.r.t to poller position.
Signed-off-by: Sugu Sougoumarane ssougou@gmail.com