Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable query consolidation by default for master tablet types #4058

Open
dweitzman opened this issue Jun 28, 2018 · 0 comments
Open

Disable query consolidation by default for master tablet types #4058

dweitzman opened this issue Jun 28, 2018 · 0 comments

Comments

@dweitzman
Copy link
Member

dweitzman commented Jun 28, 2018

The documented consistency model is that master reads outside transactions have read-committed behavior (https://vitess.io/user-guide/scalability-philosophy/#consistency-model). This is not true in practice: query consolidation on master means that non-transactional master reads are not consistent

I think it makes more sense to default to the safe, intuitive behavior and let people opt-in to the riskier, higher throughput behavior if they feel it will provide value for their specific use cases.

Regardless of whether the default changes, having a flag to disable query consolidation only on master tablets seems valuable.

dweitzman added a commit to dweitzman/vitess that referenced this issue Feb 26, 2020
This diff creates the possibility to start a tablet with
"-enable-consolidator=false -enable-consolidator-replicas" so
that query consolidation is enabled only for non-master instance
types.

This allows using the consolidator while keeping the agreement that
OLTP reads from master have read-committed consistency while replicas
have inconsistent reads.

See vitessio#4058

Signed-off-by: David Weitzman <dweitzman@pinterest.com>
@ajm188 ajm188 removed the P3 label Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants