-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yosys Update -> v0.42 #2596
Yosys Update -> v0.42 #2596
Conversation
Thanks @amirarjmand93
vtr_reg_nightly_test1/arithmetic_tasks/figure_8...[Fail]
|
Thanks for your attention @vaughnbetz . Errors: [Run-tests (vtr_reg_nightly_test1, 16)]
[Run-tests (parmys_reg_strong, 16, -DYOSYS_F4PGA_PLUGINS=ON)]
I will debug it. Quick Update 1 [Run-tests (vtr_reg_nightly_test1, 16)] command :
Solution: |
Quick Update 2[Run-tests (parmys_reg_strong, 16, -DYOSYS_F4PGA_PLUGINS=ON)] f4pga-plugins conflict with Yosys v0.42 [building error] command:
possibly, The last Yosys version compatible with f4pga-plugins is v0.38 ( I've checked. it still use multirange_dimensions vector) can see these changes in v0.32(current) and v0.42 of Yosys here: https://github.com/search?q=repo%3AYosysHQ%2Fyosys+frontends%2Fast+dimensions&type=code |
Thanks @amirarjmand93 . Can you change f4pga-plugins to use the new dimensions vector? |
I've noticed that this modification isn't just a simple name change. In summary, "multirange_dimensions" and "dimensions" serve different purposes in the code snippets. "multirange_dimensions" is used to store range or dimension-related values, while "dimensions" is used to store dimension-specific information as tuples or objects.
|
Thanks. I suspect raising an issue in yosys is also a good idea. |
@vaughnbetz i provided these spreadsheets for tasks which have gotten QoR failures . list of QoR failure tasks:
arithmetic_tasks/figure_8/:
arithmetic_tasks/multless_consts/:
arithmetic_tasks/open_cores/:
power_extended_arch_list:
vtr_reg_nightly_test3/vtr_reg_qor_chain_depop:
vtr_reg_strong/strong_two_chains:
vtr_reg_strong/strong_blocks_with_no_inputs:
vtr_reg_nightly_test4/koios_medium:
comparison files are here : |
This mostly looks OK, but there are a few missing or crazy numbers; are those run failures? |
There are some QoR failures that I have attached here. After parsing the results using parse_vtr_task.py, I utilized the qor_compare.py script. However, this script encounters issues when trying to calculate the ratio sheets, as it leaves some metric values blank or with huge discrepancies. maybe it arises from column incompatibility between the Golden result and Parsing result sheets. the number of columns is unequal. |
…A_PLUGINS=ON] test in test.yml
9faf691
to
baa5607
Compare
I manually lined up some numbers from koios_medium, and they look OK (pre-packed blocks, post-packed blocks, post-packed nets, placement time, placement wirelength, placement cpd are all up or down slightly and fine). |
Since we have existing QoR data (@MohamedElgammal has it for the VTR 9 paper) I'll merge this, and @MohamedElgammal if you can generate new front end QoR for VTR and Koios we can use it as a double check, and for the VTR 9 paper. |
@vaughnbetz have you seen my commit? I turned off two tests completely. vtr_reg_system_verilog and parmys_reg_strong. |
I suggest making a separate PR to turn the relevant tests back on then; getting them turned on ASAP would be a good idea as having CI tests turned off lets new bugs slip through. Since there was no [WIP] in the title and no comment on pending testing for this I assumed it was ready to merge. |
Description
This update brings Yosys to the latest version, 0.42, which includes several bug fixes, performance improvements, and new features that enhance the synthesis capabilities of our flow. Notable additions in this version include :
-New commands and options
-Verific support
-Added support for using the ABCs library
-Added support for VHDL 2009
...
For a detailed list of changes and improvements in Yosys 0.42 (June 7, 2024), please refer to the release notes.
Related Issue
-Update Yosys [The latest version in the VTR flow is 0.32]
Types of changes