-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keymaps #1509
Closed
Closed
Keymaps #1509
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
1bca3ba
Add base Keymaps
ppot dad0094
add emojs shortcut
ppot 287dc24
remove accelerators
ppot 68865e1
remove menu.js
ppot 7a67ef5
keys removes
ppot bbc5cf9
mv for asar
ppot 0584894
review
ppot b1bfe9a
Update plugins installation
ppot 6845bb7
test keymaps as commands
ppot f78c8b3
Add command-registry
ppot cf1ab0c
Update command registration
ppot 4c8aa03
remove spaces
ppot 97a30be
mv CommandRegistry inside hterm
ppot 117ddeb
change fuction name
ppot 0ed2e34
remove code comments
ppot 2d272c5
exports _toDependencies
ppot 0b98739
Cleaning
ppot ffea76b
comments and fnct name change
ppot 7a5139c
SyntaxError handling
ppot 378f5ed
fixed issue where old config file was read as a byte buffer rather th…
MartyGentillon b53426b
Fixed issue with keymap case sensitivity
MartyGentillon bfa92d8
simplification
ppot 231451b
Set 1 -> load with default config if errors
ppot bdea424
Step 2 -> Provide notifications error
ppot 2ba0431
Add keybind for windows:zoom
ppot 33e2333
Remove file
ppot 5f74ab4
Word change
ppot e680f4f
Add DEV paths for dev testing
ppot 182d347
const and file rename
ppot ddab1d5
update website
ppot 7cb6f34
rebase
ppot 41b5699
rename hconf.js to config.js on website
ppot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens when the configuration fails to parse? It seems that some kind of notification or error dialogue would be useful
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: issue #1589
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added handling of this in SyntaxError
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When there is a syntax error in the configuration, the application still fails to start.
When that happens, we should probably load the default configuration until the syntax error is resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I thought:
What if instead of copying default config to a file. We use them and overide them only if the user updated is inside his local config.js file?
It will be easier and if error are found we can still lunch hyper and display better notification inside the shell.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One really nice thing about that approach: if there is some new item of configuration, it comes configured by default, which could be really nice. Another thought, perhaps the way to deal with the documentation for custom configuration would be to write the default config into the hyper config directory as an "information" file, along with instructions for generating the config.js.
Something like default_config.js.info with the following disclaimer:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rauchg What is your take on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it easier for users to have a well documented file to modify than copy or create a new one. imho
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really the right place to discuss about it, but maybe it could be a great idea to have a specific section for plugin configuration.
Because of this: chabou/hyper-pane#9 and this chabou/hyper-autoprofile#2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can open an Issue for this since it's a distinct question to be addressed!