Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not overwrite defaults #9

Closed
caillou opened this issue Apr 20, 2017 · 2 comments
Closed

Can not overwrite defaults #9

caillou opened this issue Apr 20, 2017 · 2 comments

Comments

@caillou
Copy link

caillou commented Apr 20, 2017

Thanks for you brilliant effort with this plugin.

I use Hyper v1.3.1 and the latest hyper-pane.

I can not seem to be able to overwrite the defaults given the following config:

  module.exports = {
    config: {
      fontSize: 12,
      fontFamily: 'Menlo, "DejaVu Sans Mono", Consolas, "Lucida Console", monospace',
      cursorColor: 'rgba(248,28,229,0.8)',
      cursorShape: 'BLOCK',
      cursorBlink: false,
      foregroundColor: '#fff',
      backgroundColor: '#000',
      borderColor: '#333',
      css: '',
      termCSS: '',
      showHamburgerMenu: '',
      showWindowControls: '',
      padding: '12px 14px',
      colors: {
        black: '#000000',
        red: '#ff0000',
        green: '#33ff00',
        yellow: '#ffff00',
        blue: '#0066ff',
        magenta: '#cc00ff',
        cyan: '#00ffff',
        white: '#d0d0d0',
        lightBlack: '#808080',
        lightRed: '#ff0000',
        lightGreen: '#33ff00',
        lightYellow: '#ffff00',
        lightBlue: '#0066ff',
        lightMagenta: '#cc00ff',
        lightCyan: '#00ffff',
        lightWhite: '#ffffff'
      },
      shell: '',
      shellArgs: ['--login'],
      env: {},
      bell: false,
      copyOnSelect: false
    },
    paneNavigation: {
      hotkeys: {
        navigation: {
          up: 'meta+alt+up',
          down: 'meta+alt+down',
          left: 'meta+alt+left',
          right: 'meta+alt+right'
        },
      },
      showIndicators: false,
    },
    plugins: [
      'hyper-pane', // Enhance pane navigation
      'hyperlayout', // Layout presets
      'hypercwd', // Opens new tabs with the same directory as the current tab
      'hyperlinks', // automatically links URLs
      'hyperterm-safepaste', // Makes pasting into hyperterm safe
    ],
    localPlugins: [],
  };
@chabou
Copy link
Owner

chabou commented Apr 20, 2017

Thank you for your feedback. I will try to reproduce it soon.

@chabou
Copy link
Owner

chabou commented Apr 22, 2017

Ok, your config file is malformed. paneNavigation should be a children of config.

module.exports = {
  config: {
    fontSize: 12,
    fontFamily: 'Menlo, "DejaVu Sans Mono", Consolas, "Lucida Console", monospace',
    cursorColor: 'rgba(248,28,229,0.8)',
    cursorShape: 'BLOCK',
    cursorBlink: false,
    foregroundColor: '#fff',
    backgroundColor: '#000',
    borderColor: '#333',
    css: '',
    termCSS: '',
    showHamburgerMenu: '',
    showWindowControls: '',
    padding: '12px 14px',
    colors: {
      black: '#000000',
      red: '#ff0000',
      green: '#33ff00',
      yellow: '#ffff00',
      blue: '#0066ff',
      magenta: '#cc00ff',
      cyan: '#00ffff',
      white: '#d0d0d0',
      lightBlack: '#808080',
      lightRed: '#ff0000',
      lightGreen: '#33ff00',
      lightYellow: '#ffff00',
      lightBlue: '#0066ff',
      lightMagenta: '#cc00ff',
      lightCyan: '#00ffff',
      lightWhite: '#ffffff'
    },
    shell: '',
    shellArgs: ['--login'],
    env: {},
    bell: false,
    copyOnSelect: false,
    paneNavigation: {
      hotkeys: {
        navigation: {
          up: 'meta+alt+up',
          down: 'meta+alt+down',
          left: 'meta+alt+left',
          right: 'meta+alt+right'
        },
      },
      showIndicators: false
    },
  },
  
  plugins: [
    'hyper-pane', // Enhance pane navigation
    'hyperlayout', // Layout presets
    'hypercwd', // Opens new tabs with the same directory as the current tab
    'hyperlinks', // automatically links URLs
    'hyperterm-safepaste', // Makes pasting into hyperterm safe
  ],
  localPlugins: [],
};

Be careful, meta+alt+left and meta+alt+right is used by Hyper to navigate between tabs. Both will be triggered. It is not possible yet to override Hyper shortcuts, but @ppot is working on it (vercel/hyper#1509).
But if you use only one tab, it's ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants