Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashes on open with invalid config #1589

Closed
2 tasks done
sambass1 opened this issue Feb 27, 2017 · 13 comments · Fixed by #5025
Closed
2 tasks done

Crashes on open with invalid config #1589

sambass1 opened this issue Feb 27, 2017 · 13 comments · Fixed by #5025
Labels
good first issue Issue is good for Hyper newcomers help wanted Contributions wanted towards the issue 🎨 Type: Enhancement Issue or PR is an enhancement request/proposal for Hyper

Comments

@sambass1
Copy link

sambass1 commented Feb 27, 2017

  • I am on the latest Hyper.app version
  • I have searched the issues of this repo and believe that this is not a duplicate
  • OS version and name: <macOS Sierra 10.12.3>
  • Hyper.app version: <Hyper 1.2.1>

When I open Hyper the terminal open and closed quickly. The app is still open however. When I click on preferences in the menu bar the below pop up box shows. I've tried uninstalling and reinstalling but same problem occurs.

A JavaScript error occurred in the main process
Uncaught Exception:
TypeError: Cannot read property 'write' of undefined
at Server.rpc.on (/Applications/Hyper.app/Contents/Resources/app/index.js:269:24)
at emitOne (events.js:96:13)
at Server.emit (events.js:188:7)
at Server.ipcListener (/Applications/Hyper.app/Contents/Resources/app/rpc.js:34:11)
at emitTwo (events.js:106:13)
at EventEmitter.emit (events.js:191:7)
at WebContents. (/Applications/Hyper.app/Contents/Resources/electron.asar/browser/api/web-contents.js:219:13)
at emitTwo (events.js:106:13)
at WebContents.emit (events.js:191:7)

@Anzumana
Copy link

Anzumana commented Feb 27, 2017

How did you uninstall the app? You could try https://freemacsoft.net/appcleaner/
And then reinstall. Have 10.12.2 and can't reproduce the issue. Not sure when i will have time to upgrade to 10.12.3

@sambass1
Copy link
Author

I used appcleaner to remove it and still the same issue. Also installed the older version of Hyper and the same problem.

I think it's an issue in the preferences but I can't edit those without using the terminal.

@rohan-buechner
Copy link

rohan-buechner commented Feb 28, 2017

I had a similar (ish-)issue. #1581
Exact same symptoms.
In my case the plugins array had an extra comma in it.
My solution was to open the ~/.hyper.js file in a regular editor / other terminal. then make sure the file has no typos in in....

Your situation seems to be different, I'd start by removing all the plugins, then re-adding them one by one (I'm going on the assumption that the issue is plugin related)

Hope this helps.

@sambass1
Copy link
Author

Great, advice. Opened the ~/.hyper.js file in a regular editor and changed what I needed. Working fine now. Thanks @rohan-buchner

@albinekb
Copy link
Contributor

I think we should handle that error and show a nice alert so next time the user knows that there's something wrong in the Preferences👍🙌

@albinekb albinekb reopened this Feb 28, 2017
@albinekb albinekb changed the title Crashes on open Crashes on open with invalid config Feb 28, 2017
@timothyis timothyis added help wanted Contributions wanted towards the issue 🎨 Type: Enhancement Issue or PR is an enhancement request/proposal for Hyper good first issue Issue is good for Hyper newcomers labels Mar 3, 2017
@baz-sh
Copy link

baz-sh commented Mar 6, 2017

I'm having this exact problem with Windows. I also see other issues listed. I made a backup of my config before I changed it to use powershell. I'm now assuming one of my args is wrong because it just throws an uncaught exception on startup.

I could roll back my config, or try again but it isn't clear where this config file is in Windows. A reinstall cleaning the app folder makes no difference either, if you reinstall, something is lingering because it just throws again.

@aaronendsley
Copy link

I am having the same issue, mine did not trigger until i misspelled the address for bash and i tried editing the config again, no such luck so i uninstalled went back version etc, still the same error

@Anzumana
Copy link

will give it a try. and see if i can find a good solution for this issue

@fmontes
Copy link

fmontes commented Mar 16, 2017

Same issue on Windows.

shot 03152017-11 3a01

@pablopunk
Copy link
Contributor

They also have this error in the VS Code terminal and here's how they handle it. I guess listening to that error and noticing the user should be fine until something better comes up.

@jstangroome
Copy link

I have encountered this same error call stack as OP with Hyper 2.0.0 on Windows 10, but not on start up, instead whilst attempting to Ctrl+C to exit top inside an SSH session started from the Bash on Windows shell.

Uncaught Exception:
TypeError: Cannot read property 'write' of undefined
    at Server.Window.rpc.on (C:\Users\jason\AppData\Local\hyper\app-2.0.0\resources\app.asar\ui\window.js:158:16)
    at emitOne (events.js:115:13)
    at Server.emit (events.js:210:7)
    at Server.ipcListener (C:\Users\jason\AppData\Local\hyper\app-2.0.0\resources\app.asar\rpc.js:33:11)
    at emitTwo (events.js:125:13)
    at EventEmitter.emit (events.js:213:7)
    at WebContents.<anonymous> (C:\Users\jason\AppData\Local\hyper\app-2.0.0\resources\electron.asar\browser\api\web-contents.js:266:13)
    at emitTwo (events.js:125:13)
    at WebContents.emit (events.js:213:7)

@najam489
Copy link

Hi, you have to search for hyper.js file in your system and edit it by your need delete all the code if you don't know what is causing the error
I hope that will help

@elacalle
Copy link

Howdy! Can I take this issue?

Greetings!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issue is good for Hyper newcomers help wanted Contributions wanted towards the issue 🎨 Type: Enhancement Issue or PR is an enhancement request/proposal for Hyper
Projects
None yet
Development

Successfully merging a pull request may close this issue.