Show config error notfications after app is ready #5025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1589 by waiting until the app is ready to show Notifications. When the config file has a syntax error, the app is not ready so a Notification can't be created yet. In this change, notify() checks to see if the app isReady() and, if it's not, creates the Notification after the 'ready' event is issued.
Now if the config file has a syntax error, the default configuration will be used and two notifications will be sent: line 19 of init.ts issues a notification with the syntax error, and line 36 of init.ts notifies that it couldn't find the 'config' key.