fix: do not error when there are unused source nodes #6924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jheer
approved these changes
Oct 4, 2020
|
LGTM, though I don't have any deep familiarity with the dataflow optimization here. I assume the error being thrown prior to this patch is not really an "error", based on your comments regarding subsequent clean-up? |
|
The problematic spec doesn't have a dataset at the root view (it defines the same dataset in the child views). Vega-Lite instantiated an empty source node for the root, which then was removed by the optimizer. The problem was that source nodes need to be removed from the list of sources, not a tree of nodes. The code change prevents source nodes from being removed the wrong way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6897