Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not error when there are unused source nodes #6924

Merged
merged 1 commit into from
Oct 4, 2020
Merged

fix: do not error when there are unused source nodes #6924

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/compile/data/optimizers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import {FilterNode} from './filter';
import {ParseNode} from './formatparse';
import {IdentifierNode} from './identifier';
import {BottomUpOptimizer, isDataSourceNode, Optimizer, TopDownOptimizer} from './optimizer';
import {SourceNode} from './source';
import {TimeUnitNode} from './timeunit';

/**
Expand Down Expand Up @@ -219,6 +220,8 @@ export class RemoveUnusedSubtrees extends BottomUpOptimizer {
public run(node: DataFlowNode) {
if (node instanceof OutputNode || node.numChildren() > 0 || node instanceof FacetNode) {
// no need to continue with parent because it is output node or will have children (there was a fork)
} else if (node instanceof SourceNode) {
// ignore empty unused sources as they will be removed in optimizationDataflowHelper
} else {
this.setModified();
node.remove();
Expand Down