Skip to content

Commit

Permalink
fix: do not error when there are unused source nodes (#6924)
Browse files Browse the repository at this point in the history
fixes #6897
  • Loading branch information
domoritz authored Oct 4, 2020
1 parent 1591e8e commit b1a5312
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/compile/data/optimizers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import {FilterNode} from './filter';
import {ParseNode} from './formatparse';
import {IdentifierNode} from './identifier';
import {BottomUpOptimizer, isDataSourceNode, Optimizer, TopDownOptimizer} from './optimizer';
import {SourceNode} from './source';
import {TimeUnitNode} from './timeunit';

/**
Expand Down Expand Up @@ -219,6 +220,8 @@ export class RemoveUnusedSubtrees extends BottomUpOptimizer {
public run(node: DataFlowNode) {
if (node instanceof OutputNode || node.numChildren() > 0 || node instanceof FacetNode) {
// no need to continue with parent because it is output node or will have children (there was a fork)
} else if (node instanceof SourceNode) {
// ignore empty unused sources as they will be removed in optimizationDataflowHelper
} else {
this.setModified();
node.remove();
Expand Down

0 comments on commit b1a5312

Please sign in to comment.