Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kinetic: port UI code to Qt version 5 #95

Closed
jack-oquin opened this issue Sep 12, 2017 · 10 comments
Closed

Kinetic: port UI code to Qt version 5 #95

jack-oquin opened this issue Sep 12, 2017 · 10 comments
Assignees
Labels

Comments

@jack-oquin
Copy link
Member

As much as possible, we should try to make things work with both Qt4 and Qt5.

ref: #83

@jack-oquin
Copy link
Member Author

jack-oquin commented Sep 12, 2017

Most of the Qt code appears in these packages:

  • bwi_planning_common
  • bwi_rqt_plugins
  • multi_level_map_utils

@jack-oquin
Copy link
Member Author

It looks like our Python Qt4 scripts are using the old, deprecated SIGNAL interface. That has to be removed before migrating to Qt5.

@jack-oquin
Copy link
Member Author

Note that the commits above are all saved in the kinetic branch of this repository.

@jack-oquin
Copy link
Member Author

jack-oquin commented Oct 24, 2017

To test this with the simulator, install ROS Kinetic on an Ubuntu Xenial system.

Follow the BWI software install directions: https://github.com/utexas-bwi/bwi/blob/master/README.md

Note that the rosdep install step will not work, because there are missing dependencies in ROS Kinetic. there are missing dependencies in ROS Kinetic. You'll need to install some more ROS packages manually. I don't have an exact list. I generally end up trying to build things, installing the dependencies that turn up missing, then repeating that process until it finally works.

jack-oquin added a commit to utexas-bwi/bwi that referenced this issue Oct 24, 2017
jack-oquin added a commit to utexas-bwi/segbot that referenced this issue Oct 24, 2017
@jack-oquin
Copy link
Member Author

The transforms are working now in simulation.

@jack-oquin
Copy link
Member Author

Commit 6b43d46 is the proper way to handle the module differences between pyqt4 and pyqt5 in a compatible manner. It has not been tested with Qt4 yet, but I expect that to work.

The other module imports should be done similarly.

@jack-oquin
Copy link
Member Author

The modified pyqt imports work on Indigo, too, even using the kinetic branch:

  • The bwi_rqt_plugins question dialog window successfully.
  • The bwi_planning_common logical marker window comes up.
  • The multi_level_map_utils level selector passes its test.

@jack-oquin
Copy link
Member Author

The kinetic branch of bwi_common mostly seems to run in simulation on Indigo now, except for the difference in clingo versions. As expected, running visit_door_list fails:

[action_executor-23] process has died [pid 5417, exit code -11, cmd /home/joq/ros/trusty_indigo/devel/lib/bwi_kr_execution/single_plan_executor_node __name:=action_executor __log:=/home/joq/.ros/log/b23d0952-f89b-11e7-bb1d-001517fdbc75/action_executor-23.log].
log file: /home/joq/.ros/log/b23d0952-f89b-11e7-bb1d-001517fdbc75/action_executor-23*.log

@jack-oquin
Copy link
Member Author

jack-oquin commented Jan 19, 2018

The Python bwi_rqt_plugins seem to basically work.

The C++ image plugin builds (with Qt4), but segfaults in rqt if you launch it. It presumably needs to be ported to Qt5.

@jack-oquin
Copy link
Member Author

I don't see any use of the C++ image plugin anywhere in our three main repositories. Moreover, rqt already has an image view plugin. So, I think I'll just delete ours.

If it turns out someone actually needs it, we can go back and resurrect the old code, doing whatever porting is necessary.

jack-oquin added a commit that referenced this issue Jan 22, 2018
These programs do not work on Kinetic with Qt5. Since they are not
used, there is no point in porting or maintaining them.
@jack-oquin jack-oquin self-assigned this Jan 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant