-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kinetic: port UI code to Qt version 5 #95
Comments
Most of the Qt code appears in these packages:
|
It looks like our Python Qt4 scripts are using the old, deprecated |
Note that the commits above are all saved in the |
To test this with the simulator, install ROS Kinetic on an Ubuntu Xenial system. Follow the BWI software install directions: https://github.com/utexas-bwi/bwi/blob/master/README.md
|
…-bwi/bwi_common#95) The dialog gui launch is also temporarily commented out.
The transforms are working now in simulation. |
This tries the Qt4 modules first, then Qt5 if that fails.
Commit 6b43d46 is the proper way to handle the module differences between pyqt4 and pyqt5 in a compatible manner. It has not been tested with Qt4 yet, but I expect that to work. The other module imports should be done similarly. |
The modified pyqt imports work on Indigo, too, even using the
|
The
|
The Python bwi_rqt_plugins seem to basically work. The C++ image plugin builds (with Qt4), but segfaults in rqt if you launch it. It presumably needs to be ported to Qt5. |
I don't see any use of the C++ image plugin anywhere in our three main repositories. Moreover, rqt already has an image view plugin. So, I think I'll just delete ours. If it turns out someone actually needs it, we can go back and resurrect the old code, doing whatever porting is necessary. |
These programs do not work on Kinetic with Qt5. Since they are not used, there is no point in porting or maintaining them.
As much as possible, we should try to make things work with both Qt4 and Qt5.
ref: #83
The text was updated successfully, but these errors were encountered: